-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specification of file format for GraphML export and import #314
Comments
Re: "edge-value-id," I just added "-id" because I wanted to explicitly indicate that this expression functions as an identifier. However, in the end what is important is that the identifier is consistently used, so "edge-value" works just as well. |
I'm OK with "id" still being there, it was more of a question. I don't want my misunderstanding to trump clarity. |
We might consider using the graph id. When Cytoscape exports a graph to graphml format, it gives the graph id as the name of the file. I think this is a good thing. See the relevant line below.
|
The items listed here have been implemented (and acknowledged that there may be more to come):
|
I think we are close to closing this, pending my testing results tomorrow. |
Cool, looking forward to it :) |
Question:
These questions pertain to the I, interoperable, and R, reusable parts of the standard. |
I’ll have to look deeper into the GraphML spec for a definitive answer. If there is no direct support (such as metadata elements or attributes), we can fall back on a comment block. Also, the variability in vocabulary that we are seeing is outside the XML definition. There is a specific GraphML schema available. The issue is that the schema itself defines this generic But yes, this needs more research, and in the absence of something more structured, we can go to a comment. |
In the interests of FAIR, we want to add a comment to the GRNsight-exported GraphML: Exported by GRNsight v1.16. http://dondi.github.io/GRNsight/ link to the release time/daystamp |
This has been implemented and placed on beta. I leapfrogged to v1.18 though, since that is the version we anticipate releasing (import-export + displaying weights). Once we are back to a long-term development track, we can keep the release branch at v1.18 but bump the beta branch to v1.19 when exporting. (unless you had other thoughts on how to proceed) |
I'll check the functionality in the morning when I can pay more attention to detail. I assume that you are somehow detecting versions automatically when exporting. It seems like a lot of work to manually adjust that at release time (it seems like it would be easy to forget, like the last modified date on the web pages.) Otherwise, yeah, we were going to release v1.18 next. |
I've verified that the comment with the version, and two URLs has come through in the GraphML export from both Firefox and Chrome. I note that there was no date/timestamp, however. In the interests of time, I'm willing to let go of that--we need to move on to the release tasks #323. I did one final round of checking the following for all the demo files and options: and everything checks out. I'm going to close this now. |
Ah yes forgot to mention---the date/timestamp was tricky because it's hard to unit test. Additional code will need to be written to assert that the comment is present but either ignore a discrepancy in the date/timestamp, or somehow anticipate what the date/timestamp should be (reading the date/timestamp first and then invoking the export is not guaranteed to match because the test might cross a time unit boundary). We can get back to that when there is more elbow room. |
I'm creating this issue in parallel to #309 for discussion of GraphML. I'm going to close #287 and #288 because the basic functionality there has been implemented and we are now fine-tuning. It makes more sense now to take on the two formats separately.
I have now read through the GraphML Primer and have done a visual inspection of the GRNsight GraphML exports of an unweighted and weighted graph.
I can match up the XML elements in the primer with what GRNsight has exported, and just have one question so far:
I am now proceeding with further testing of *.graphml files moving between programs.
The text was updated successfully, but these errors were encountered: