Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing new files has some delays #1098

Open
ntran18 opened this issue Feb 26, 2024 · 3 comments
Open

Importing new files has some delays #1098

ntran18 opened this issue Feb 26, 2024 · 3 comments

Comments

@ntran18
Copy link
Collaborator

ntran18 commented Feb 26, 2024

Importing new files has some delays. For example, if you load an error file and want to reload another file, it still shows the previous error file, which needs to be re-uploaded.

@ntran18
Copy link
Collaborator Author

ntran18 commented Oct 17, 2024

I investigated this issue only in Chrome, not Safari. So the problem happens because of the web browser.

@dondi
Copy link
Owner

dondi commented Oct 23, 2024

Verified that this is a Chrome-only issue (Firefox does not manifest the problem either)

However due to Chrome’s popularity, it will be worth tracing the specific divergent behavior that Chrome is manifesting which cases the file selector to appear twice. Once we pinpoint that, we can determine if there is a way to address the divergent behavior without also regressing the other browsers

@ntran18
Copy link
Collaborator Author

ntran18 commented Oct 25, 2024

The root cause was that when the user clicks on "Select New File," it triggers ".upload".click(). But the class upload is bound to two Open File buttons: one in the sidebar and one at the top bar, which trigger the file selector twice.

ntran18 added a commit that referenced this issue Oct 30, 2024
dondi added a commit that referenced this issue Nov 4, 2024
#1098 Fixing file selector appears twice after importing wrong file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants