Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Coloring Coordination between top menu and side panel #1055

Closed
ntran18 opened this issue Oct 11, 2023 · 4 comments
Closed

Node Coloring Coordination between top menu and side panel #1055

ntran18 opened this issue Oct 11, 2023 · 4 comments

Comments

@ntran18
Copy link
Collaborator

ntran18 commented Oct 11, 2023

I already see that feature in the version 7.0.2 beta. However, there is different options between the top menu and the side panel.

  • Side panel:
image
  • Top menu:
image

--> Users can still select top data or bottom data from the top menu, not from the side panel.

@ntran18 ntran18 changed the title Node Coloring and Protein- Protein Mode Node Coloring Coordination Oct 12, 2023
@ntran18 ntran18 assigned ntran18 and nchun2 and unassigned ntran18 and nchun2 Oct 12, 2023
@nchun2
Copy link
Collaborator

nchun2 commented Oct 16, 2023

I tried to replicate this issue on beta, and it allows me to select node coloring from both the top and side menus, but only the side menu seems to act on the change. When I click on either option, it consistently moves the nodes further away from each other. I don't know if this is supposed to happen or if it actually matters, but I just wanted to note that.
Screenshot (114)
Clicking the option from the top menu moves the nodes further away from each other, but it does not change their color. After it is clicked it also does not have the check next to it to indicate that it has been clicked.
Screenshot (115)
Screenshot (116)
For the side menu, it does keep the check and it changes the color of the nodes from white to grey.

@kdahlquist kdahlquist changed the title Node Coloring Coordination Node Coloring Coordination between top menu and side panel Oct 31, 2023
@ntran18
Copy link
Collaborator Author

ntran18 commented Feb 20, 2024

I think this problem can be closed. This issue was solved in one of the other issues (#1033 probably). The issue that @nchun2 mentioned meaning data pulled from protein-protein interactions allowed node coloring, which shouldn't be. The option is disabled in beta branch currently.
image

@kdahlquist
Copy link
Collaborator

In beta 7.0.11, I have verified that node coloring is disabled (completely grayed out) if the first network you choose is a PPI network. However, if you open a GRN first and then open a PPI, the Node coloring top menu is not grayed out and you can select options there, even though they do not act on the graph. The Node side panel will allow you to check the "Enable node coloring" box. If you check the box, it will color the nodes a uniform light gray color.

ntran18 added a commit that referenced this issue Oct 23, 2024
dondi added a commit that referenced this issue Oct 23, 2024
#1055 Make the node coloring menu for top bar and side bar to be cons…
dondi added a commit that referenced this issue Oct 23, 2024
@dondi
Copy link
Owner

dondi commented Oct 23, 2024

The original reported problem appears to have been separated into more distinct issues now, so closing this one

@dondi dondi closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants