Keyboard handling overhaul: Cmd/Ctrl shortcuts trigger tools, single keys mutate BOTH panels' calibration, Esc collisions, pen-undo ordering race

[dompm]

Both panels register window keydown handlers (ResultPanel.tsx:922-972, SheetPanel.tsx:196-220) with structural problems that produce data corruption from ordinary keystrokes:

1. No modifier guards

Handlers check bare e.key with no metaKey/ctrlKey/altKey checks:

• Cmd/Ctrl+C (copy) → both panels switch to crop mode. Cmd/Ctrl+V → select tool. Cmd/Ctrl+S → ResultPanel toggles refine-remove mode (ResultPanel.tsx:946) and the browser Save dialog opens (no preventDefault).

2. Shortcuts fire into both panels — and fabricate calibration data

Neither handler scopes to the hovered/focused panel. Pressing M activates measure on both canvases, and handleToolChange('measure') writes data on both sides: a default 6-inch scale on the pattern (ResultPanel.tsx:1358-1365) and on the active sheet (SheetPanel.tsx:399-402). One keystroke intended for one panel silently fabricates a calibration for the other — and a wrong sheet scale corrupts every downstream real-world size computation.

Fix: a single shared useCanvasShortcuts(panel) hook with modifier guards and hover/focus scoping (see the ResultPanel-split refactor issue).

3. Pen-tool Cmd+Z race: one keystroke, two destructive actions

ResultPanel.tsx:952-958 relies on e.stopImmediatePropagation() to block App's global undo — which only works if ResultPanel's listener registered before App's. But App re-registers on selectedPieceIds/undo/redo changes (App.tsx:711 deps) and ResultPanel re-registers on activeTool change (ResultPanel.tsx:990); window listeners run in registration order. Switch to the pen tool (listener now last), place vertices, press Cmd+Z → App's handler runs first and reverts the last committed project op (e.g. deletes the previously created piece), then ResultPanel pops the pen vertex.

4. Esc collisions with modals

No Esc handler stops propagation and panels don't know a modal is open (ResultPanel.tsx:959-972, ShortcutsOverlay.tsx:67-77, MoveConfirmDialog.tsx:17-24). Mid-pen-drawing, open the shortcuts overlay (?), press Esc to close it → ResultPanel discards the in-progress polygon and SheetPanel resets its tool.

5. Delete inside the sheet <select> deletes the piece

App's global guard (App.tsx:678) excludes only HTMLInputElement/HTMLTextAreaElement — not HTMLSelectElement (the panels' own guards do, e.g. ResultPanel.tsx:923). Focus the "Sheet" dropdown in the piece popover, press Delete/Backspace → deletePieces(selectedPieceIds) deletes the piece being edited.

6. Stale closures in the keydown effect

Deps are [activeTool] only (ResultPanel.tsx:990): updateHoverPoint reads unrolledLamp state directly at :804 (inconsistent with the ref at :719), so Shift re-snap uses stale lamp geometry after a profile edit; 'b' at :939 checks a stale isEncoding; keyboard handleToolChange('m') reads a stale project.patternCrop. Related: App's keyboard effect (App.tsx:711) lists deletePiece in deps but uses deletePieces, which closes over isSymmetryEnabled — toggle symmetry then press Delete and the stale handler applies the old symmetry mode.

[dompm]

Partial fix landed on branch worktree-agent-a4a9a3a5a0d883e50 (commit 83703c5):

• Point 2 (SheetPanel side): the glass panel's v/h/c/m/Escape shortcuts are now scoped to the hovered panel via a pointerenter/leave ref, so a keystroke meant for the pattern panel no longer switches the sheet tool — and m no longer fabricates a default 6-inch sheet calibration.
• Point 6 (App side): the piece-deletion keydown effect now lists deletePieces (the function it actually calls) in its deps, so toggling symmetry can no longer leave a stale handler applying the old symmetry mode on Delete.

Already fixed by #108: point 1's modifier guards in SheetPanel, and point 5 (HTMLSelectElement guard in App's handler).

Still open:

• ResultPanel side of points 1, 2, and 6 (modifier guards incl. Cmd+S preventDefault, hover scoping, stale keydown-effect closures) — being handled separately.
• Point 3 (pen-tool Cmd+Z registration-order race).
• Point 4 (Esc collisions): hover scoping only mitigates the SheetPanel half; ShortcutsOverlay/MoveConfirmDialog still need to stop Esc propagation.

Related new issue: #112 (Cmd+Shift+Z redo dead branch in the same App handler).

[dompm]

Partial fix on branch worktree-agent-a74496986766d6075 (53d7180) for item 4 (Esc collisions), modal side: ShortcutsOverlay and MoveConfirmDialog now handle Escape in the capture phase and call stopPropagation()/preventDefault(), so the Esc that dismisses a modal is consumed before ResultPanel/SheetPanel window handlers can reset tools or discard an in-progress pen polygon. editor-basher hover-scoped SheetPanel's handling separately. Items 1–3, 5–6 remain open.

[dompm]

ResultPanel-side fixes on the worktree-agent branch (commit 9c9642a):

• Item 3 (pen Cmd+Z ordering race): ResultPanel's keydown/keyup listeners now register once in the capture phase, so the pen tool's vertex-pop always runs before App's bubble-phase undo listener regardless of re-registration order.
• Item 6 (stale closures): the handlers dispatch through a ref to the latest render's closures — 'b' no longer sees a stale isEncoding after encoding finishes, 'm' no longer calibrates against a stale patternCrop, Shift re-snap uses the current updateHoverPoint.

Still open: panel scoping (item 2 — single keys still fire into both panels; needs the shared useCanvasShortcuts hook) and Esc/modal collisions (item 4).