[3.x] Use PHPUnit 12 #2961
Merged
[3.x] Use PHPUnit 12 #2961
+37
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the test suite to use PHPUnit 12, addressing deprecations and adopting new best practices introduced in PHPUnit 12.
- Updates PHPUnit dependency from
^10.5.58|^11.5.43to^12.5.1 - Migrates deprecated
isType('array')assertions toisArray() - Converts mocks without expectations to stubs using
createStub() - Updates type hint syntax to use intersection types (
Type&MockObject) - Fixes data provider parameter structure to avoid providing unused arguments
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updates PHPUnit requirement to version 12.5.1 |
| tests/Tests/UnitOfWorkTest.php | Replaces deprecated isType('array') with isArray() |
| tests/Tests/SchemaManagerTest.php | Converts mocks to stubs where no expectations are set, updates type hints to intersection syntax, adds atLeast(0) expectations to maintain mock behavior |
| tests/Tests/QueryTest.php | Converts cursor mocks to stubs, updates type hints, removes unused imports |
| tests/Tests/Query/BuilderTest.php | Consolidates data provider parameters for near() and nearSphere() methods, updates type hints |
| tests/Tests/Proxy/Factory/ProxyFactoryTest.php | Updates type hint syntax to intersection type |
| tests/Tests/Functional/SplObjectHashCollisionsTest.php | Adds int $leftover parameter to test method signature to match data provider |
| tests/Tests/Functional/DocumentPersisterTest.php | Replaces deprecated isType('array') with isArray() across multiple test methods |
| tests/Tests/Events/OnClassMetadataNotFoundEventArgsTest.php | Converts mock to stub where no expectations are needed |
| tests/Tests/Aggregation/AggregationTestTrait.php | Updates type hints to intersection syntax |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
IonBazan
commented
Dec 6, 2025
Comment on lines
+500
to
+501
| 'near()' => ['near', [[1, 2], null, 5, 10]], | ||
| 'nearSphere()' => ['nearSphere', [[1, 2], null, 5, 10]], |
Member
Author
There was a problem hiding this comment.
This caused extra arguments to be provided to the test. It only accepts 2 arguments and the second one must be array. I believe it was causing unexpected results.
GromNaN
approved these changes
Dec 6, 2025
Comment on lines
+500
to
+501
| 'near()' => ['near', [[1, 2], null, 5, 10]], | ||
| 'nearSphere()' => ['nearSphere', [[1, 2], null, 5, 10]], |
Member
|
Thank you @IonBazan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates tests to use PHPUnit 12 features and avoids deprecations:
isType('array')->isArray()