You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think I might have found a suitable approach for getting unit tests running with PHP 8.0.
I'd like to discuss the changes proposed in #739 with you. First, as discussed on Slack, we are using symbols from laminas-(mvc-)console in src without required that package explicitly (it is in suggest, though). Therefore, at first, I have identified these placed, added an appropriate check on top of the file and use trigger_error to generate a runtime error in case someone tries using that classes without having the suggestion installed.
Next, I have deprecated the related symbols so that we can remove them with the next major version. To allow running the unit tests with PHP 8, I used --ignore-platform-req=php. I know that this is not the best choice, but I think we don't really have a chance to do otherwise. Besides laminas-(mvc-)console, there is laminas-cache as well, which still isn't fully PHP8-compatible (at lest withouth manually replacing legacy cache adapters, see docs).
Personally, I think we can go this way. I cannot think of a scenario where this will break someones application. We are continuing to support under PHP 7.3 & 7.4 what we have supported before and we are continuing not to support under PHP 8.0 what we have never supported before. What do you guys think?
I think I might have found a suitable approach for getting unit tests running with PHP 8.0.
I'd like to discuss the changes proposed in #739 with you. First, as discussed on Slack, we are using symbols from laminas-(mvc-)console in
src
without required that package explicitly (it is insuggest
, though). Therefore, at first, I have identified these placed, added an appropriate check on top of the file and usetrigger_error
to generate a runtime error in case someone tries using that classes without having the suggestion installed.Next, I have deprecated the related symbols so that we can remove them with the next major version. To allow running the unit tests with PHP 8, I used
--ignore-platform-req=php
. I know that this is not the best choice, but I think we don't really have a chance to do otherwise. Besides laminas-(mvc-)console, there is laminas-cache as well, which still isn't fully PHP8-compatible (at lest withouth manually replacing legacy cache adapters, see docs).Personally, I think we can go this way. I cannot think of a scenario where this will break someones application. We are continuing to support under PHP 7.3 & 7.4 what we have supported before and we are continuing not to support under PHP 8.0 what we have never supported before. What do you guys think?
cc @TomHAnderson @greg0ire
The text was updated successfully, but these errors were encountered: