Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check 5_14 maximum attempts or maximum retry should be <= 5. #538

Closed
codefrogs opened this issue Sep 22, 2023 · 3 comments · Fixed by #539
Closed

check 5_14 maximum attempts or maximum retry should be <= 5. #538

codefrogs opened this issue Sep 22, 2023 · 3 comments · Fixed by #539
Assignees
@konstruktoid

Comments

@codefrogs
Copy link

If a container stops restarts for 0-5 times then this is secure. Containers should not fail because the maximum attempts/retries is less then 5.
See line 614 of 5_container_runtime.sh function check_5_14
@konstruktoid
Copy link
Collaborator

Hi @codefrogs and thanks for creating this issue, I'll have a look as soon as possible.

@konstruktoid
Copy link
Collaborator

Yeah, you right. "You should use the on-failure restart policy to limit the number of
container restarts to a maximum of 5 attempts."

@konstruktoid
Copy link
Collaborator

So sorry for the delay, could you please test #539?

@konstruktoid konstruktoid linked a pull request Feb 11, 2024 that will close this issue
check if restart policy is 5 or less #539
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konstruktoid konstruktoid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check if restart policy is 5 or less konstruktoid/docker-bench-security
2 participants
@konstruktoid @codefrogs