Skip to content

Commit caeebb7

Browse files
committed
e2e: add docker v29-rc
Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent 171a9b7 commit caeebb7

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

.github/workflows/e2e.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ jobs:
3737
- alpine
3838
- debian
3939
engine-version:
40+
- 29-rc # latest rc
4041
- 28 # latest
4142
- 27 # latest - 1
4243
- 25 # mirantis lts

e2e/image/push_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import (
1010
"github.com/docker/cli/internal/test/environment"
1111
"github.com/docker/cli/internal/test/output"
1212
"gotest.tools/v3/assert"
13+
is "gotest.tools/v3/assert/cmp"
1314
"gotest.tools/v3/fs"
1415
"gotest.tools/v3/golden"
1516
"gotest.tools/v3/icmd"
@@ -84,8 +85,9 @@ func TestPushQuietErrors(t *testing.T) {
8485
result := icmd.RunCmd(icmd.Command("docker", "push", "--quiet", "nosuchimage"))
8586
result.Assert(t, icmd.Expected{
8687
ExitCode: 1,
87-
Err: "An image does not exist locally with the tag: nosuchimage",
8888
})
89+
assert.Check(t, is.Contains(result.Stderr(), "does not exist"))
90+
assert.Check(t, is.Contains(result.Stderr(), "nosuchimage"))
8991
}
9092

9193
func TestPushWithContentTrustUnreachableServer(t *testing.T) {

0 commit comments

Comments
 (0)