Skip to content

Commit a45f2aa

Browse files
committed
Add HEALTHCHECK instruction to Dockerfile.
The `Dockerfile` currently does not have a `HEALTHCHECK` instruction. Users of the Docker image currently need to add it manually (e.g. via Docker Compose). Instead, the `Dockerfile` itself should include the instruction. To determine whether the service is healthy, one can use the [`pg_isready`](https://www.postgresql.org/docs/current/app-pg-isready.html) program, which is already part of the image. The program “checks the connection status of a PostgreSQL database server”. Most of the default `HEALTHCHECK` [options](https://docs.docker.com/reference/dockerfile/#healthcheck) seem reasonable: ``` --interval=30s --timeout=30s --start-interval=5s --retries=3 ``` I set `--start-period=1s` because the default of `0s` is too quick for this program. Users of the image can still override the `HEALTHCHECK` instruction if they want to customize the command or the options.
1 parent 805329e commit a45f2aa

File tree

26 files changed

+52
-0
lines changed

26 files changed

+52
-0
lines changed

12/alpine3.19/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

12/alpine3.20/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

12/bookworm/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

12/bullseye/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

13/alpine3.19/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

13/alpine3.20/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

13/bookworm/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

13/bullseye/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

14/alpine3.19/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

14/alpine3.20/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

14/bookworm/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

14/bullseye/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

15/alpine3.19/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

15/alpine3.20/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

15/bookworm/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

15/bullseye/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

16/alpine3.19/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

16/alpine3.20/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

16/bookworm/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

16/bullseye/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

17/alpine3.19/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

17/alpine3.20/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

17/bookworm/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

17/bullseye/Dockerfile

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Dockerfile-alpine.template

+2
Original file line numberDiff line numberDiff line change
@@ -250,3 +250,5 @@ STOPSIGNAL SIGINT
250250

251251
EXPOSE 5432
252252
CMD ["postgres"]
253+
254+
HEALTHCHECK --start-period=1s CMD pg_isready || exit 1

Dockerfile-debian.template

+2
Original file line numberDiff line numberDiff line change
@@ -221,3 +221,5 @@ STOPSIGNAL SIGINT
221221

222222
EXPOSE 5432
223223
CMD ["postgres"]
224+
225+
HEALTHCHECK --start-period=1s CMD pg_isready || exit 1

0 commit comments

Comments
 (0)