Make BuildInfosExtensions null safe, add helper methods

Author: gesellix

api-client/src/main/kotlin/de/gesellix/docker/remote/api/client/BuildInfoExtensions.kt

@@ -12,13 +12,19 @@ fun List<BuildInfo>.getImageId(): ImageID? {
     return firstAux.get().aux
   } else {
     val idFromStream = reversedInfos.stream()
-      .filter { (_, stream): BuildInfo -> stream?.contains("Successfully built ")!! }
+      .filter { (_, stream): BuildInfo ->
+        val contains = stream?.contains("Successfully built ")
+        contains != null && contains
+      }
       .findFirst()
     return if (idFromStream.isPresent) {
       ImageID(idFromStream.get().stream!!.removePrefix("Successfully built ").replaceAfter('\n', "").trim())
     } else {
       val tagFromStream = reversedInfos.stream()
-        .filter { (_, stream): BuildInfo -> stream?.contains("Successfully tagged ")!! }
+        .filter { (_, stream): BuildInfo ->
+          val contains = stream?.contains("Successfully tagged ")
+          contains != null && contains
+        }
         .findFirst()
       tagFromStream.map { (_, stream): BuildInfo ->
         ImageID(stream!!.removePrefix("Successfully tagged ").replaceAfter('\n', "").trim())
@@ -27,3 +33,15 @@ fun List<BuildInfo>.getImageId(): ImageID? {
     }
   }
 }
+
+fun List<BuildInfo>.getError(): BuildInfo? {
+  return this.stream()
+    .filter { (_, _, error): BuildInfo -> error != null }
+    .findFirst()
+    .orElse(null)
+}
+
+fun List<BuildInfo>.hasError(): Boolean {
+  return this.stream()
+    .anyMatch { (_, _, error): BuildInfo -> error != null }
+}

api-client/src/test/java/de/gesellix/docker/remote/api/client/BuildInfoExtensionsTest.java

@@ -1,16 +1,60 @@
 package de.gesellix.docker.remote.api.client;
 
 import de.gesellix.docker.remote.api.BuildInfo;
+import de.gesellix.docker.remote.api.ErrorDetail;
 import de.gesellix.docker.remote.api.ImageID;
 import org.junit.jupiter.api.Test;
 
 import java.util.ArrayList;
 import java.util.List;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 class BuildInfoExtensionsTest {
 
+  @Test
+  public void getErrorFromFailedBuild() {
+    List<BuildInfo> infos = new ArrayList<>();
+    infos.add(new BuildInfo(null, null, "invalid reference format", new ErrorDetail(null, "invalid reference format"), null, null, null, null));
+
+    BuildInfo errorInfo = BuildInfoExtensionsKt.getError(infos);
+
+    assertEquals("invalid reference format", errorInfo.getError());
+  }
+
+  @Test
+  public void getHasErrorInFailedBuild() {
+    List<BuildInfo> infos = new ArrayList<>();
+    infos.add(new BuildInfo(null, null, "invalid reference format", new ErrorDetail(null, "invalid reference format"), null, null, null, null));
+
+    boolean hasError = BuildInfoExtensionsKt.hasError(infos);
+
+    assertTrue(hasError);
+  }
+
+  @Test
+  public void getHasNoErrorInSuccessfulBuild() {
+    List<BuildInfo> infos = new ArrayList<>();
+    infos.add(new BuildInfo(null, "Successfully built the wind\ncaught it", null, null, null, null, null, null));
+
+    boolean hasError = BuildInfoExtensionsKt.hasError(infos);
+
+    assertFalse(hasError);
+  }
+
+  @Test
+  public void getImageIdFromFailedBuild() {
+    List<BuildInfo> infos = new ArrayList<>();
+    infos.add(new BuildInfo(null, null, "invalid reference format", new ErrorDetail(null, "invalid reference format"), null, null, null, null));
+
+    ImageID imageId = BuildInfoExtensionsKt.getImageId(infos);
+
+    assertNull(imageId);
+  }
+
   @Test
   public void getImageIdFromAux() {
     List<BuildInfo> infos = new ArrayList<>();