Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask environment variable values in logs #272

Open
hawkeyexl opened this issue Feb 4, 2025 · 0 comments
Open

Mask environment variable values in logs #272

hawkeyexl opened this issue Feb 4, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@hawkeyexl
Copy link
Contributor

Environment variables are most commonly used to temporarily store secrets, but today Doc Detective emits all resolved values in logs, including those that come from environment variables. This is particularly problematic when typing sensitive values like usernames and passwords that shouldn't be displayed as plaintext.

While there is a workaround to use the GitHub Action to leverage GitHub's native environment variable masking, we still need to support this natively.

This behavior is most important to typing, but it also applies to API keys and other secrets, so it should really be supported globally. That said, sometimes it's useful to know exactly which values were fetched, like with URLs, so maybe there should be some sort of visibility setting? Some way to distinguish between a variable and a secret?

cc @JakeSCahill

@hawkeyexl hawkeyexl added the enhancement New feature or request label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant