Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement async variants of methods that make HTTP requests #42

Open
ghost opened this issue Mar 22, 2023 · 1 comment
Open

Implement async variants of methods that make HTTP requests #42

ghost opened this issue Mar 22, 2023 · 1 comment
Labels
enhancement New feature, enhancement or code changes, not related to defects

Comments

@ghost
Copy link

ghost commented Mar 22, 2023

Currently we make blocking calls when we make HTTP requests to the API server, which makes this library unusable from async contexts, common in most projects that make network requests. We should implement async variants of methods on our service structs, which will require moving away from our ureq dependency which does not support async. We should probably use Tokio and reqwest.

@ghost ghost added the enhancement New feature, enhancement or code changes, not related to defects label Mar 22, 2023
@ghost ghost self-assigned this Mar 22, 2023
@dallasread
Copy link
Member

We would like to address this in the future – as it is important for most contexts. We're open to a PR that introduces this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, enhancement or code changes, not related to defects
Projects
None yet
Development

No branches or pull requests

1 participant