Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

비회원 사용자 생성 #23

Merged
merged 24 commits into from
Feb 2, 2025
Merged

비회원 사용자 생성 #23

merged 24 commits into from
Feb 2, 2025

Conversation

choyeseol
Copy link
Collaborator

#️⃣연관된 이슈

#18

🔀반영 브랜치

feat/#18-non-member -> develop

🔧변경 사항

  • 회원/비회원 여부를 isGuest로 설정하면, 회원일 경우 false가 되기에 isMember로 바꿔 회원일 경우 true가 되게 했습니다.
  • 비회원의 임시 이름을 Guest로 설정했습니다.
  • 비회원의 만료일을 생성일로부터 1달 후로 설정했습니다.
  • UUID를 사용해 비회원의 임시 이메일을 할당했습니다.

💬리뷰 요구사항(선택)

  • 수정해야할 부분이나 궁금한 부분이 있다면 말씀해주세요!

@choyeseol choyeseol added the ✨ Feature 기능 개발 label Feb 1, 2025
@choyeseol choyeseol requested a review from sudhdkso February 1, 2025 13:40
@choyeseol choyeseol linked an issue Feb 1, 2025 that may be closed by this pull request
1 task
Copy link

github-actions bot commented Feb 1, 2025

📝 테스트 커버리지 리포트입니다!

File Coverage [49.15%]
Authority.java 100% 🍏
User.java 100% 🍏
UserNotFoundException.java 50% 🍏
UserRepository.java 50% 🍏
AuthController.java 0%
AuthService.java 0%
Total Project Coverage 60.2% 🍏

Copy link
Member

@sudhdkso sudhdkso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예설님 수고하셨습니다👍👍 코드 보면서 몇개 리뷰남겨봅니다!

Copy link
Member

@sudhdkso sudhdkso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하실 부분있으시면 수정하시고 병합해주세요! 승인은 코멘트랑 따로 작성해야해서 미리 승인 내려놓겠습니다!

Copy link

github-actions bot commented Feb 2, 2025

📝 테스트 커버리지 리포트입니다!

File Coverage [49.57%]
Authority.java 100% 🍏
User.java 100% 🍏
UserNotFoundException.java 50% 🍏
UserRepository.java 50% 🍏
AuthController.java 0%
AuthService.java 0%
Total Project Coverage 60.4% 🍏

@choyeseol choyeseol merged commit 9026559 into develop Feb 2, 2025
2 checks passed
@choyeseol choyeseol deleted the feat/#18--non-member branch February 2, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

비회원 사용자 생성
2 participants