Installation steps of kvdo on Debian 11(.3)

[tigerblue77]

Hello everyone,

I wrote this little script to install kvdo on Debian 11(.3) (tested with 5.10.0-13 Linux kernel)

DEPENDANCIES="git make linux-headers-$(uname -r)"
WORK_DIRECTORY="/tmp/kvdo/"

apt update && \
apt install -y $DEPENDANCIES && \
#git clone https://github.com/dm-vdo/kvdo.git $WORK_DIRECTORY && \
git clone https://github.com/tigerblue77/kvdo.git $WORK_DIRECTORY && \
cd $WORK_DIRECTORY && \
make -j $(nproc) -C /usr/src/linux-headers-`uname -r` M=`pwd` && \
cd - && \
cp ${WORK_DIRECTORY}vdo/kvdo.ko /lib/modules/$(uname -r) && \
cp ${WORK_DIRECTORY}uds/uds.ko /lib/modules/$(uname -r) && \
apt autoremove --purge -y $DEPENDANCIES && \
rm -Rf $WORK_DIRECTORY

depmod
#update-initramfs -u
#echo uds >>/etc/modules && \
#echo kvdo >> /etc/modules
modprobe kvdo
modprobe uds

• Line 6 is commented while waiting for my pull request Restore <5.15 kernels support #52 to be merged
• Can anyone tell me if lines 17-19 are needed ?
• Is there a way to make the 13 and 14 lines run in parallel while keeping line 12 "&&" ? (solved in comments)
• Don't hesitate to suggest any improvment !
• Once improved, maybe we could add this script to repository's README.md ?
• This script is part of my full kvdo + vdo installation script, don't hesitate to check the issue I opened on vdo's github repository

I wrote this script with help of those forum topics :

• https://forum.proxmox.com/threads/lvmvdo-doesnt-deduplicate-my-data.103132/
• https://unix.stackexchange.com/questions/686472/lvmvdo-doesnt-deduplicate-my-data
• https://unix.stackexchange.com/questions/518549/compiling-vdo-for-use-on-debian

[tigerblue77]

Script improved (thanks to this topic) :

install_dependencies() {
    (( ${#} > 1 )) && {
        apt update && \
        apt install -y "$@"
    } || echo "No dependency to install"
}

clean_dependencies() {
    (( ${#} > 1 )) && {
        apt autoremove --purge -y "$@"
    } || echo "No dependency to remove"
}

clone_repo() {
    (( ${#} == 1 )) && {
        TEMPDIR=$(mktemp -d "/tmp/${1/*\/}.XXX") && \
        git clone "$1" "${TEMPDIR}" && \
        cd "$TEMPDIR" && \
        pwd -P
    }
}

# Usage: clean $WORK_DIRECTORY $DEPENDENCIES
clean() {
    (( ${#} >= 1 )) && {
        clean_dependencies "${*:2}" > /dev/null 2>&1 &
        rm -Rf "$1" &
        wait
    }
}

# First part : KVDO module
DEPENDENCIES="git make linux-headers-$(uname -r)"
install_dependencies $DEPENDENCIES > /dev/null 2>&1
WORK_DIR="$(clone_repo https://github.com/tigerblue77/kvdo.git)"
(
    cd "${WORK_DIR}" && \
    make -j"$(nproc)" -C "/usr/src/linux-headers-$(uname -r)" M="${WORK_DIR}"
) > kvdo_build.log 2>&1

cp "${WORK_DIR}/vdo/kvdo.ko" "${WORK_DIR}/uds/uds.ko" "/lib/modules/$(uname -r)"
clean "${WORK_DIR}" $DEPENDENCIES

depmod --quick
#update-initramfs -u
#echo uds >>/etc/modules && \
#echo kvdo >> /etc/modules
modprobe kvdo
modprobe uds

It now :

• creates kvdo_build.log file instead of writing full output to console.
• runs lines 26 and 27 in parallel 26 and 27 run in parallel

[marneu]

Testing bookworm and kvdo/8.2.6.3:
version fails in debian 6.1.37 if creating the kmod (but not related to the kernel version)
in dm-vdo-target.c:99 a question for #if (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(9, 6)) makes the compilation fail.

[lorelei-sakai]

Hi. Could you show the details of the compilation failure? I see one thing that I think needs fixing, but as long as I'm making a change I want to make sure I can address the whole issue. Thanks.

[marneu]

Unfortunately i've reconfigured the test server meanwhile.
So i don't have a copy of the log anymore, but what I remember it was only the RHEL_RELEASE_CODE is not defined on a Debian system. So you should just make sure the variable exists before continuing with the compare. hth

[lorelei-sakai]

Okay, if that's the only issue it's easy enough to fix. Sorry about the oversight on our part. I expect we should be able to get a fix within a couple of days.

[lorelei-sakai]

The new 8.2.6.5 release should address this issue.