Regression #20777: wrong line numbers diagnosed in inline asm

[ibuclaw]

Example:

module asm1;



// Gap intentional



void main()
{
    asm { "" [; }
}

Reports:

asm1.d(1): Error: expression expected, not `;`
module asm1;
^
asm1.d(1): Error: found `End of File` when expecting `,`
module asm1;
 ^
asm1.d(1): Error: found `End of File` when expecting `]`
module asm1;
 ^
asm1.d(1): Error: found `End of File` when expecting `;`
module asm1;
 ^

Introduced by #20777

[dkorpel]

Do you have a test case for dmd?

[ibuclaw]

Do you have a test case for dmd?

Not without adding a call to gccAsmSemantic in dmd's branch for asm semantic.

Looking at the change, I suspect it might be a new requirement to fix up the starting line?

https://github.com/dlang/dmd/pull/20777/files#diff-862192b33df815981dcb4a8a49bc7dc572506b444a7dc034fde3643f887e2982R5931

[dkorpel]

Yes, gccAsmSemantic does p.scanloc = s.loc; which doesn't work anymore. I'll see if I can unittest that function.