Update committees urls #2308
Open
Update committees urls #2308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahboyce
reviewed
Nov 16, 2025
Contributor
sarahboyce
left a comment
sarahboyce
left a comment
There was a problem hiding this comment.
Thank you for the PR! I have a few nit picks
Note that the code of conduct committee is now the code of conduct working group and I think it makes sense to update the team naming throughout the site 👍
| <ul class="list-links"> | ||
| <li><a href="{% url 'code_of_conduct' %}">{% translate "Code of Conduct" %}</a></li> | ||
| <li><a href="/foundation/committees/#conduct">{% translate "Committee" %}</a></li> | ||
| <li><a href="{% url 'members:teams' %}#code-of-conduct-team">{% translate "Committee" %}</a></li> |
Contributor
There was a problem hiding this comment.
Suggested change
| <li><a href="{% url 'members:teams' %}#code-of-conduct-team">{% translate "Committee" %}</a></li> | |
| <li><a href="{% url 'members:teams' %}#code-of-conduct-team">{% translate "Code of Conduct working group" %}</a></li> |
Comment on lines
+24
to
+30
| {% with coc_teams_url=teams_url|add:'#code-of-conduct-team' %} | ||
| <p> | ||
| {% blocktranslate trimmed %} | ||
| All responses to reports of conduct violations will be managed by a | ||
| <a href="{{ coc_teams_url }}">Code of Conduct Committee</a> ("the committee"). | ||
| {% endblocktranslate %}</p> | ||
| {% endwith %} |
Contributor
There was a problem hiding this comment.
Suggested change
| {% with coc_teams_url=teams_url|add:'#code-of-conduct-team' %} | |
| <p> | |
| {% blocktranslate trimmed %} | |
| All responses to reports of conduct violations will be managed by a | |
| <a href="{{ coc_teams_url }}">Code of Conduct Committee</a> ("the committee"). | |
| {% endblocktranslate %}</p> | |
| {% endwith %} | |
| <p> | |
| {% blocktranslate trimmed %} | |
| All responses to reports of conduct violations will be managed by the | |
| <a href="{{ teams_url }}#code-of-conduct-team">Code of Conduct working group</a>. | |
| {% endblocktranslate %}</p> |
Personally I wouldn't bother with the use of add and save an indent/extra logic here
| msgid "" | ||
| "All responses to reports of conduct violations will be managed by a <a " | ||
| "href=\"/foundation/committees/\">Code of Conduct Committee</a> (\"the " | ||
| "href=\"{coc_teams_url}\">Code of Conduct Committee</a> (\"the " |
Contributor
There was a problem hiding this comment.
I feel like more translation file updates are required, however, I don't think we use the translations on the website so I'm not sure we are keeping this up-to-date (maybe @marksweb can clarify here?)
Member
|
Hello @pgaca, do you plan on addressing the review comments here, or should I close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #2257
Replaced hardcoded committees URL with variable to teams page URL (anchored to the CoC team).