Skip to content

Conversation

@rsebille
Copy link

@rsebille rsebille commented Oct 31, 2025

Not all code branches are tested and it's mostly coverage works but it should prevent simple errors or regression while simplify adding or improving tests for those views.

There is one point to discuss, it's the FIXME in the document views.

@sarahboyce
Copy link
Contributor

sarahboyce commented Nov 17, 2025

I aim to review this soon, in the meantime can you resolve the conflicts? 🙏
Also these new tests appear to fail, can you take a look?

@sarahboyce sarahboyce assigned sarahboyce and unassigned sarahboyce Nov 17, 2025
@rsebille rsebille force-pushed the rsebille/pyconfr/add-tests branch from 0076bf8 to 139d414 Compare December 1, 2025 09:52
@rsebille
Copy link
Author

rsebille commented Dec 1, 2025

I aim to review this soon, in the meantime can you resolve the conflicts? 🙏 Also these new tests appear to fail, can you take a look?

Sorry for the delay, the branch is rebased.
I will try to investigate the failing tests this week-end, I must have missed something as they all pass when I use docker compose run --rm web python -m manage test but didn't find any of the usual suspects :/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants