Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for fundraising web hooks #1722

Open
bmispelon opened this issue Nov 5, 2024 · 0 comments · May be fixed by #1808
Open

Add more tests for fundraising web hooks #1722

bmispelon opened this issue Nov 5, 2024 · 0 comments · May be fixed by #1808
Labels
help-needed Help needed python Pull requests that update Python code

Comments

@bmispelon
Copy link
Member

bmispelon commented Nov 5, 2024

It seems that the code in fundraising.views.WebhookHandler doesn't have any tests associated with it.

It would be nice to have a basic suite of tests, at least for the "happy path". This could prevent bugs like the one fixed recently in e995213.

EDIT: Not sure how I managed to miss it, but we do have some tests: https://github.com/django/djangoproject.com/blob/main/fundraising/tests/test_views.py#L183
So I'm narrowing down the scope of this to adding tests for the hooks that are not currently being tested (like checkout_session_completed)

@bmispelon bmispelon added python Pull requests that update Python code help-needed Help needed labels Nov 5, 2024
@bmispelon bmispelon changed the title Add tests for fundraising web hooks Add more tests for fundraising web hooks Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-needed Help needed python Pull requests that update Python code
Projects
None yet
1 participant