Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR status only take the first check into account #225

Open
bmispelon opened this issue Nov 7, 2024 · 2 comments
Open

PR status only take the first check into account #225

bmispelon opened this issue Nov 7, 2024 · 2 comments
Labels

Comments

@bmispelon
Copy link
Member

I was confused today because my PR was marked as "build: success" on Trac, but it had fail on github.

Investigating the issue, I discovered that the javascript that figures out the status of a PR only takes the first check into account:

build_state = data[0].state;

Considering we have around 50 checks, I don't think this logic is accurate.

I would suggest that the status should be "building" if any individual check has status=building, "error" if at least one check has status=error, and "success" only if all checks have status=success (not sure if there are other statues to take into account)

@bmispelon bmispelon added the bug label Nov 7, 2024
@dev-akshaygupta
Copy link

dev-akshaygupta commented Nov 8, 2024

Hey @bmispelon,
I'm eagerly looking for contributing to the Open Source Projects. This will be my first.
I would like to contribute to this one.

@dev-akshaygupta
Copy link

@bmispelon
Any feedback on the PR is most welcome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@bmispelon @dev-akshaygupta and others