Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Type Annotations to asgiref Module Functions #428

Open
davitacols opened this issue Dec 23, 2023 · 4 comments
Open

Add Type Annotations to asgiref Module Functions #428

davitacols opened this issue Dec 23, 2023 · 4 comments

Comments

@davitacols
Copy link

I suggest adding type annotations to the following functions in the asgiref module:

  1. is_double_callable
  2. double_to_single_callable
  3. guarantee_single_callable

Proposed Changes:

  • Add type annotations to function parameters and return types in the specified functions.

Benefits:

  • Improved code readability.
  • Better tooling support for developers using the asgiref module.

Additional Context:
This change aims to enhance the maintainability and clarity of the asgiref codebase by incorporating type annotations into key functions.

@andrewgodwin
Copy link
Member

Sounds reasonable - I'll happily take a pull request for this.

@davitacols
Copy link
Author

I am happy you found this useful.
Best.

@Joao-antonio-gg
Copy link

Hello, can i try this Pr?

@davitacols
Copy link
Author

Hello, can i try this Pr?

Pls go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants