ci: add mypy and pre-commit

Author: samineer

.github/workflows/python-package.yml

@@ -36,9 +36,9 @@ jobs:
           os: ubuntu-20.04
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@v5
       with:
         python-version: ${{ matrix.python-version }}
         allow-prereleases: true
@@ -56,27 +56,24 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v3
-    - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v4
+    - uses: actions/checkout@v4
+    - uses: actions/setup-python@v5
       with:
-        python-version: "3.8"
-    - name: Install dependencies
-      run: |
+        python-version: "3.12"
+    - uses: pre-commit/[email protected]
+
+  type:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v4
+    - uses: actions/setup-python@v5
+      with:
+        python-version: "3.12"
+    - run: |
         python -m pip install -U pip
         pip install .
-        pip install flake8 check-manifest
-    - name: Lint with isort
-      uses: isort/isort-action@master
-    - name: Lint with flake8
-      if: success() || failure()
-      run: |
-        flake8 --version
-        flake8
-    - name: Lint with check-manifest
-      if: success() || failure()
-      run: |
-        check-manifest
-    - name: Lint with black
-      if: success() || failure()
-      uses: psf/black@stable
+        pip install -r requirements-type.txt
+    - run: |
+        mypy src/

.pre-commit-config.yaml

@@ -1,13 +1,13 @@
 default_language_version:
-    python: python3.11
+    python: python3.12
 repos:
   - repo: 'https://github.com/pre-commit/pre-commit-hooks'
     rev: v4.5.0
     hooks:
       - id: trailing-whitespace
       - id: end-of-file-fixer
   - repo: 'https://github.com/PyCQA/flake8'
-    rev: 6.1.0
+    rev: 7.0.0
     hooks:
       - id: flake8
   - repo: 'https://github.com/pre-commit/mirrors-isort'
@@ -19,18 +19,18 @@ repos:
     hooks:
       - id: check-manifest
   - repo: 'https://github.com/myint/autoflake'
-    rev: v2.2.1
+    rev: v2.3.0
     hooks:
       - id: autoflake
         args:
           - '--remove-all-unused-imports'
           - '-i'
   - repo: https://github.com/psf/black-pre-commit-mirror
-    rev: 23.9.1
+    rev: 24.2.0
     hooks:
       - id: black
   - repo: https://github.com/asottile/pyupgrade
-    rev: v3.15.0
+    rev: v3.15.1
     hooks:
       - id: pyupgrade
         entry: pyupgrade --py3-plus --py36-plus --keep-runtime-typing

requirements-type.txt

@@ -0,0 +1,3 @@
+mypy>=1.8.0
+types-pytz
+types-babel

src/fluent_compiler/ast_compat.py

@@ -23,6 +23,7 @@ def NewAst(...):
       NewAst = ast.NewAst
 
 """
+
 import ast
 import sys
 

tox.ini

@@ -1,31 +1,24 @@
 # This config is for local testing. Where needed changes should be duplicated into
 # .github/workflows/pythonpackage.yml
 [tox]
-envlist = py36,py37,py38,py39,py310,py311,py312,pypy3.6,flake8,isort
+envlist =
+    py{36,37,38,39,310,311,312},
+    pypy{3.6,3.7,3.8,3.9,3.10},
+    lint,
+    type,
 # For Python 3.6 support:
 requires = virtualenv<20.22.0
 
 [testenv]
-deps =
-     # Just '.[develop]' would be nice here.
-     # Unfortunately it is super slow: https://github.com/pypa/pip/issues/2195
-     # So we duplicate deps from setup.py for now.
-     -r{toxinidir}/requirements.txt
-     -r{toxinidir}/requirements-test.txt
-     -r{toxinidir}/requirements-linters.txt
+deps = -r{toxinidir}/requirements-test.txt
 commands = pytest
 
+[testenv:lint]
+base_python = py312
+deps = pre-commit
+commands = pre-commit run --all-files --show-diff-on-failure
 
-[testenv:flake8]
-basepython = python3.9
-commands = flake8 src tests
-
-
-[testenv:isort]
-basepython = python3.9
-commands = isort -c src tests
-
-[testenv:check-manifest]
-basepython = python3.9
-deps = check-manifest
-commands = check-manifest
+[testenv:type]
+base_python = py312
+deps = -r{toxinidir}/requirements-type.txt
+commands = mypy src/