[cluster] support rename cluster

Author: jackblack369

cli/command/cluster/cmd.go

@@ -31,22 +31,23 @@ import (
 	"github.com/spf13/cobra"
 )
 
-func NewClusterCommand(curveadm *cli.DingoAdm) *cobra.Command {
+func NewClusterCommand(dingoadm *cli.DingoAdm) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "cluster",
 		Short: "Manage clusters",
 		Args:  cliutil.NoArgs,
-		RunE:  cliutil.ShowHelp(curveadm.Err()),
+		RunE:  cliutil.ShowHelp(dingoadm.Err()),
 	}
 
 	cmd.AddCommand(
-		NewAddCommand(curveadm),
-		NewCheckoutCommand(curveadm),
-		NewListCommand(curveadm),
-		NewRemoveCommand(curveadm),
+		NewAddCommand(dingoadm),
+		NewCheckoutCommand(dingoadm),
+		NewListCommand(dingoadm),
+		NewRemoveCommand(dingoadm),
 		// TODO(P1): enable export
 		//NewExportCommand(curveadm),
-		NewImportCommand(curveadm),
+		NewImportCommand(dingoadm),
+		NewRenameCommand(dingoadm),
 	)
 	return cmd
 }

cli/command/cluster/rename.go

@@ -0,0 +1,88 @@
+/*
+ * 	Copyright (c) 2025 dingodb.com Inc.
+ *
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+package cluster
+
+import (
+	"github.com/dingodb/dingoadm/cli/cli"
+	"github.com/dingodb/dingoadm/internal/errno"
+	tui "github.com/dingodb/dingoadm/internal/tui/common"
+	cliutil "github.com/dingodb/dingoadm/internal/utils"
+	log "github.com/dingodb/dingoadm/pkg/log/glg"
+	"github.com/spf13/cobra"
+)
+
+type renameOptions struct {
+	clusterOldName string
+	clusterNewName string
+	force          bool
+}
+
+func NewRenameCommand(dingoadm *cli.DingoAdm) *cobra.Command {
+	var options renameOptions
+
+	cmd := &cobra.Command{
+		Use:   "rename CLUSTER [OPTIONS]",
+		Short: "Rename cluster",
+		Args:  cliutil.ExactArgs(2),
+		RunE: func(cmd *cobra.Command, args []string) error {
+			options.clusterOldName = args[0]
+			options.clusterNewName = args[1]
+
+			return runRename(dingoadm, options)
+		},
+		DisableFlagsInUseLine: true,
+	}
+
+	flags := cmd.Flags()
+	flags.BoolVarP(&options.force, "force", "f", false, "Remove cluster by force")
+
+	return cmd
+}
+
+func runRename(dingoadm *cli.DingoAdm, options renameOptions) error {
+	// 1) get cluster by name
+	storage := dingoadm.Storage()
+	clusterOldName := options.clusterOldName
+	clusterNewName := options.clusterNewName
+	clusters, err := storage.GetClusters(clusterOldName) // Get all clusters
+	if err != nil {
+		log.Error("Get cluster failed",
+			log.Field("error", err))
+		return errno.ERR_GET_ALL_CLUSTERS_FAILED.E(err)
+	} else if len(clusters) == 0 {
+		return errno.ERR_CLUSTER_NOT_FOUND.
+			F("cluster name: %s", clusterOldName)
+	}
+
+	// rename cluster name
+	if options.force {
+		dingoadm.WriteOut(tui.PromptRenameCluster(clusterOldName, clusterNewName))
+	} else {
+		if !tui.ConfirmYes(tui.PromptRenameCluster(clusterOldName, clusterNewName)) {
+			dingoadm.WriteOut(tui.PromptCancelOpetation("rename cluster"))
+			return errno.ERR_CANCEL_OPERATION
+		}
+	}
+
+	if err := dingoadm.Storage().RenameClusterName(clusterOldName, clusterNewName); err != nil {
+		return errno.ERR_RENAME_CLUSTER_FAILED.E(err)
+	}
+
+	// 3) print success prompt
+	dingoadm.WriteOutln("Rename cluster '%s' to '%s'", clusterOldName, clusterNewName)
+	return nil
+}

internal/errno/errno.go

@@ -215,6 +215,7 @@ var (
 	ERR_DELETE_CLUSTER_FAILED          = EC(111005, "execute SQL failed which delete cluster")
 	ERR_UPDATE_CLUSTER_TOPOLOGY_FAILED = EC(111006, "execute SQL failed which update cluster topology")
 	ERR_UPDATE_CLUSTER_POOL_FAILED     = EC(111007, "execute SQL failed which update cluster pool")
+	ERR_RENAME_CLUSTER_FAILED          = EC(111008, "execute SQL failed which rename cluster")
 	// 112: database/SQL (execute SQL statement: containers table)
 	ERR_INSERT_SERVICE_CONTAINER_ID_FAILED   = EC(112000, "execute SQL failed which insert service container id")
 	ERR_SET_SERVICE_CONTAINER_ID_FAILED      = EC(112001, "execute SQL failed which set service container id")

internal/storage/sql.go

@@ -153,6 +153,9 @@ var (
 
 	// set cluster pool
 	SetClusterPool = `UPDATE clusters SET topology = ?, pool = ? WHERE id = ?`
+
+	// rename cluster name
+	RenameClusterName = `UPDATE clusters SET name = ? WHERE name = ?`
 )
 
 // service

internal/storage/storage.go

@@ -169,6 +169,17 @@ func (s *Storage) DeleteCluster(name string) error {
 	return s.write(DeleteCluster, name)
 }
 
+// RenameClusterName update cluster name, and return error if new name exists
+func (s *Storage) RenameClusterName(oldName, newName string) error {
+	clusters, err := s.GetClusters(newName)
+	if err != nil {
+		return err
+	} else if len(clusters) > 0 {
+		return fmt.Errorf("cluster name already exists: %s", newName)
+	}
+	return s.write(RenameClusterName, newName, oldName)
+}
+
 func (s *Storage) getClusters(query string, args ...interface{}) ([]Cluster, error) {
 	result, err := s.db.Query(query, args...)
 	if err != nil {

internal/tui/common/prompt.go

@@ -125,6 +125,13 @@ func PromptRemoveCluster(clusterName string) string {
 	return prompt.Build()
 }
 
+func PromptRenameCluster(clusterOldName string, clusterNewName string) string {
+	prompt := NewPrompt(color.YellowString(PROMPT_WARNING) + DEFAULT_CONFIRM_PROMPT)
+	prompt.data["warning"] = fmt.Sprintf("WARNING: cluster '%s' will be renamed to '%s'",
+		clusterOldName, clusterNewName)
+	return prompt.Build()
+}
+
 func PromptFormat() string {
 	return color.YellowString(PROMPT_FORMAT)
 }

pkg/variable/variables.go

@@ -153,6 +153,6 @@ func (vars *Variables) Rendering(s string) (string, error) {
 
 func (vars *Variables) Debug() {
 	for _, v := range vars.m {
-		log.Info("Variable", log.Field(v.Name, v.Value))
+		log.Debug("Variable", log.Field(v.Name, v.Value))
 	}
 }