Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Angular Universal #183

Closed
wants to merge 2 commits into from

Conversation

dirkgroenen
Copy link
Contributor

document is not available during Server Side Rendering. By using the 'he' library we're no longer depending on the DOM to exist, adding support for Angular Universal.

Fixes #149

'document' is not available during Server Side Rendering.
By using the 'he' library we're no longer depending on the DOM
to exist, adding support for Angular Universal.
@dirkgroenen
Copy link
Contributor Author

Not sure what's causing CircleCI to fail. Dependencies have been included and tests run fine on a fresh environment.
image

@dirkgroenen
Copy link
Contributor Author

@dimpu sorry for bothering, bot any change of looking at this one?

@dirkgroenen
Copy link
Contributor Author

@dimpu any change of getting this merged?

@h3xx
Copy link
Contributor

h3xx commented Jul 21, 2021

@dirkgroenen Try this:

  1. Rebase off my branch h3xx:ci-use-yarn
  2. Use yarn add he to add the package instead of npm. This should also update yarn.lock. You'll also want to undo your changes to npm-shrinkwrap.json.
  3. Push and cross fingers.

I re-wrote your commit to do all this if you look at #213.

@dimpu dimpu closed this in #213 Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular Universal (server side rendering) support
2 participants