Incorrect narrow_phase collisions after using ColliderSet::set_parent #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be should be removed from graph_indices too?
Vrixyz
commented
Oct 18, 2024
| @@ -455,12 +455,34 @@ impl NarrowPhase { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // Remove the new parent from the collision graphs | |||
There was a problem hiding this comment.
Suggested change
| // Remove the new parent from the collision graphs | |
| // Remove the new parent from the contact and intersection graphs |
Also, shouldn´t we remove that from graph_indices too?
Vrixyz
commented
Nov 6, 2024
Comment on lines
+1334
to
+1336
| /* Create collider 2. Parent it to rigid body 1. */ | ||
| //let collider_2_handle = | ||
| // collider_set.insert_with_parent(collider.build(), body_2_handle, &mut rigid_body_set); |
Comment on lines
+1422
to
+1423
| // TODO: this is probably a way too big value to test, consider lowering it. | ||
| // In the meantime, this proves that current behaviour is incorrect. |
Comment on lines
+1268
to
+1274
| narrow_phase.add_pair( | ||
| &collider_set, | ||
| &ColliderPair { | ||
| collider1: collider_2_handle, | ||
| collider2: collider_1_handle, | ||
| }, | ||
| ); |
There was a problem hiding this comment.
This is an internal api which we can't advocate for. a proper fix is still needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 tests + the fix for the 2d scenario.
A workaround is done for 1st scenario, but it's not usable by users.