add reapply_lost_speed to KinematicCharacterController #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vrixyz
reviewed
Jun 7, 2024
src/control/character_controller.rs
Outdated
Comment on lines
275
to
320
| if self.slide && self.reapply_lost_speed { | ||
| let diff = | ||
| pre_slide_translation_remaining.norm() - translation_remaining.norm(); | ||
| if let Some((normalized_dir, _)) = | ||
| // threshold has to be > subtract_hit hardcoded correction, if not, we get made up movement in the direction of the hit normal | ||
| UnitVector::try_new_and_get(translation_remaining, 1.0e-4) | ||
| { | ||
| // reapply the lost speed (but in the corrected direction) | ||
| translation_remaining += *normalized_dir * diff; | ||
| } | ||
| } |
There was a problem hiding this comment.
That condition should probably be in case there is no stairs ? otherwise we might end up intersecting with the stair. (and it might result in not going up the stair, or worse an infinite loop ?)
There was a problem hiding this comment.
indeed, but even with the reapply in the if !self.handle_stairs, reapplying the speed can be slightly flaky, especially in 3d
im turning the PR back into a draft and looking into it
ntibi
force-pushed
the
kcc_reapply_lost_speed
branch
from
0c8a7c0 to
617428e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
reapply_lost_speed: boolto KinematicCharacterControllerWhen set to true, the velocity lost by sliding will be reapplied to the corrected direction
so the character moves at the same speed wether it's sliding or not