Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add point in polygon test using winding counting method #173

Merged
merged 3 commits into from
Mar 24, 2024

Conversation

kurtlawrence
Copy link
Contributor

Fixes #172

Since this method is different to the one defined, namely that it does not short-circuit, I have left the original.

@sebcrozet sebcrozet force-pushed the pt-in-poly-winding branch from a2f3c9d to ea45aa4 Compare March 24, 2024 10:49
@sebcrozet
Copy link
Member

sebcrozet commented Mar 24, 2024

Thanks! I renamed the existing method to point_in_convex_poly2d (since it didn’t handle non-convex polygons anyway), so that your implementation can take the point_in_poly2d name.

@sebcrozet sebcrozet merged commit c599c39 into dimforge:master Mar 24, 2024
5 checks passed
@kurtlawrence kurtlawrence deleted the pt-in-poly-winding branch March 25, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Point in polygon 2D test failure
2 participants