Clarify logic for deleting / archiving working copy of assistants

[snopoke]

I think the logic and conditions for deleting / archiving assistants needs to be revised / reviewed. I think there are cases where we should be cleaning up on openai where we aren't and perhaps visa version.

Initial thoughts:

• don't delete if there are other usages (other experiments / pipeline nodes)

Local delete (archive)

• archive self
• archive versions
• delete openai assistant for all versions

Hard delete:

• Same as above but also delete working version from openai

See code:

• open-chat-studio/apps/assistants/views.py

  Lines 183 to 210 in 32e4c79

  	class DeleteOpenAiAssistant(LoginAndTeamRequiredMixin, View, PermissionRequiredMixin):
  	permission_required = "assistants.delete_openaiassistant"
  	@transaction.atomic()
  	def delete(self, request, team_slug: str, pk: int):
  	assistant = get_object_or_404(OpenAiAssistant, team=request.team, pk=pk)
  	if assistant.working_version_id is None and not assistant.is_archived:
  	messages.warning(request, "Cannot delete a versioned assistant without first archiving.")
  	return HttpResponse(status=400)
  	try:
  	delete_openai_assistant(assistant)
  	except OpenAiSyncError as e:
  	messages.error(request, f"Error deleting assistant from OpenAI: {e}")
  	return HttpResponse(status=500)
  	assistant.delete()
  	messages.success(request, "Assistant Deleted")
  	return HttpResponse()
  	class LocalDeleteOpenAiAssistant(LoginAndTeamRequiredMixin, View, PermissionRequiredMixin):
  	permission_required = "assistants.delete_openaiassistant"
  	@transaction.atomic()
  	def delete(self, request, team_slug: str, pk: int):
  	assistant = get_object_or_404(OpenAiAssistant, team=request.team, pk=pk)
  	assistant.archive()
  	messages.success(request, "Assistant Archived")
  	return HttpResponse()

• better checks for when to delete assistant from openai #989

[snopoke]

I also noticed that if you try to delete an assistant is says you must archive it first (but there's no archive button - only a delete button which actually does archive).

If you archive it, then it is removed from the table and you can't access it again to delete it.

Edit: made some small fixes here: #991