Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ModernHttpRequesterMock with MockWebServer #2649

Open
shubham1g5 opened this issue Feb 28, 2023 · 0 comments
Open

Replace ModernHttpRequesterMock with MockWebServer #2649

shubham1g5 opened this issue Feb 28, 2023 · 0 comments
Labels
product/invisible

Comments

@shubham1g5
Copy link
Contributor

Currently we use ModernHttpRequesterMock in unit tests to test out the http requests. We should replace this with OkHttp MockWebServer in order to make tests more dependable by relying on an universal mock library rather than something that we setup in our tests. This will allow us to test network requests directly with okHTTP layer which is the ultimate source of truth for us for network requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
product/invisible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shubham1g5