Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should exit counts capture exit reasons? #13

Open
jwdeitch opened this issue May 4, 2021 · 3 comments
Open

should exit counts capture exit reasons? #13

jwdeitch opened this issue May 4, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@jwdeitch
Copy link

jwdeitch commented May 4, 2021

particularly interested in capturing the number of times the exit reason is stated as EXCEPTION_OR_NMI ? 👼
any interest in this?

@jdesfossez
Copy link
Contributor

jdesfossez commented May 4, 2021

Yes definitely, and it would be easy to add in the current ebpf script, the issue we have is reporting, there are 60+ exit reasons IIRC and I don't think we want one column for each (either on the console or the CSV).
For the CSV I think we could maybe dump a dict-like structure in a field: {HLT: 1; NMI: 42, ...} do you have another idea ?
And on the console, I just don't know :-)

@jwdeitch
Copy link
Author

jwdeitch commented May 5, 2021

hmm good q - I'll try the csv dump (I agree w/ the dict-like structure). not sure either about prometheus or console :) - I will give it some thought

@jdesfossez
Copy link
Contributor

Prometheus will be fine because the exit reason can be a label so it won't show up unless it's used, the console is my biggest concern.
The other tools that present exit reasons live on the console (kvm_stat, perf kvm) usually only work with a filter for specific VMs or show the sum from all the VMs.
But I am fine with starting with the CSV/prometheus only and just the total on the console.

@jdesfossez jdesfossez added the enhancement New feature or request label May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants