Skip to content

Conversation

@alisnwu
Copy link

@alisnwu alisnwu commented Nov 9, 2024

closes #138

All discussions made in #158 and #163

@sbillinge Ready for review

@codecov
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (e9a7b2d) to head (ccecf10).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files           7        7           
  Lines         242      243    +1     
=======================================
+ Hits          240      241    +1     
  Misses          2        2           
Files with missing lines Coverage Δ
tests/test_loaddata.py 97.77% <100.00%> (ø)
tests/test_resample.py 94.73% <100.00%> (ø)
tests/test_serialization.py 100.00% <100.00%> (ø)

@sbillinge sbillinge merged commit 2559946 into diffpy:main Nov 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move resamplers out of parsers?

2 participants