Skip to content

Conversation

@bobleesj
Copy link
Contributor

Screenshot 2024-11-23 at 11 44 18 PM

Python 3.11-3.13 matrix test now works.

if: runner.os == 'Linux'
run: |
sudo apt-get update
sudo apt-get install -y libgtk-3-dev
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed forlinux runner in this CI to build wxpython from the sdist file. This is not needed for Windows and macOS.

@github-actions
Copy link

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

@bobleesj
Copy link
Contributor Author

@sbillinge ready for review - hopefully this resolves our CI, as well as in regolith too.

@codecov
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.31%. Comparing base (055b223) to head (0806dab).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files           6        6           
  Lines         293      293           
=======================================
  Hits          291      291           
  Misses          2        2           

@sbillinge sbillinge merged commit a1dba3c into diffpy:main Nov 25, 2024
4 of 5 checks passed
@bobleesj bobleesj deleted the wxpython-build branch November 25, 2024 19:11
@bobleesj bobleesj mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants