More code reviewers wanted!

[sgrif]

With the push to 1.0, the current pool of reviewers is starting to run low on bandwidth. We're looking for more people to help get involved with code review. You don't need to be familiar with Diesel's internals to help. Most people who have been on the Diesel core team got started by doing code review. If you're unsure what a piece of code does or why it's being done a certain way, just ask! (Make sure that the commit message doesn't answer that question already though). Don't feel like you can't ask a question just because other reviewers might already know the answer. We're happy to help you get up to speed.

[juliusdelta]

Nice. Is the best way to get started to just review and add comments/questions to PRs?

[sgrif]

Yup. If you'd like I can add you to the github group which gets pinged for code review

[juliusdelta]

Sure that’d be great!

[toddWannaCode]

I am really interested in this but I am just getting started with diesel.

[killercup]

@toddWannaCode that's absolutely fine! Most PRs are quite isolated in scope so you don't need to know everything beforehand. :) Feel free to have a look at and review PRs to get a feel for it, and if you like it, ping me (or another core team member) and we'll add you to the reviewers team.

[leshow]

I'd be interested in jumpiing into some code reviews, if you folks are still looking for people.

[killercup]

Absolutely! Want me to add you to the Reviewers team? Evan Cameron <[email protected]> schrieb am So. 24. Sep. 2017 um 23:22:

…

I'd be interested in jumpiing into some code reviews, if you folks are still looking for people. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1186 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABOX5OL_jjKy7inV3oLryKG0EqflFLaks5slsgOgaJpZM4Pf3MF> .

[toddWannaCode]

Hey I would be like to be a member of the Reviewers team. Thanks. @killercup

[killercup]

@toddWannaCode, welcome to the league of extraordinary reviewers! :)

[leshow]

@killercup Sure, sounds good.

[killercup]

@leshow, welcome to the Four Nine Horsemen of the Code Review!

[ecasilla]

Count me in also. I would love to help anyway I can.

[killercup]

@ecasilla, thank you for joining the Order of Magnitude!

[ecasilla]

@killercup How will the mentoring work exactly is there a gitter for the core team?

[sgrif]

@ecasilla You can ask questions either in the public gitter or as comments on the PRs you're trying to review (feel free to ask questions after things have been closed/merged as well)

[gsquire]

I don't have much experience in the codebase but I'd like to help review.

[jbcden]

I'm a bit late to the party and I haven't really gotten a chance to use diesel, but I'm trying to get into Rust more and would love to help with reviews!

[bahlo]

Hey, I'd also like to be in the review team.

[hrvolapeter]

Hi, count me in

[sgrif]

@retep007 I've added you to the team -- You'll get pinged on future PRs, but feel free to review any of the open PRs in the mean time. There's quite a few open right now.

[sgrif]

(Note: Everyone who's replied to this has been added shortly after replying, I'm only singling that person out because there happens to have been an extremely high volume of PRs opened in the past 24 hours and I assumed the were around right now)

[sgrif]

I should also mention -- If anyone tries to review a PR, and feels like they don't understand enough to properly review it, please ask questions on the PR. We don't mind explaining things that aren't clear, and hearing what needs more context before the PR is opened is extremely helpful.

[logotie]

Hello all, is there any chance I could please be added also? I am however very much a beginner with Rust :)

[sgrif]

Hey folks, just a heads up, I did some cleanup tonight. Anyone who hasn't commented on an issue in the past month will have been removed. If you'd like to be re-added, please comment again on this issue.

[JohnTitor]

Hi @sgrif, let me help you with reviewing! Diesel is used in my work, so improving Diesel is also important task.

[weiznich]

@JohnTitor I've added you to the reviewer team.

[AlterionX]

I would like to do some code review work! It's been lots of fun using Diesel, and I would like to get a good grasp of the internals.

[shellcodesniper]

still looking for volunteers?
I'd hope to particifate..

[weiznich]

@shellcodesniper Thanks for your interest. We are always looking for more code reviewers. I've sent you an invitation for the reviewers team. If you join that team you get notifications for each PR where a review is requested. While #3783 is a bit larger it might be a good starting point.
As written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works.

[rustacean23]

Hi! Are you still looking for code reviewers? I am studying rust and wanted to learn more by contributing to open source projects.

[weiznich]

@rustacean23 Thanks for your interest. We are always looking for more code reviewers. I've sent you an invitation for the reviewers team. If you join that team you get notifications for each PR where a review is requested. The PR #3837 is a good one to get started.
As written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works and extend your rust knowledge.

[g-hi3]

Hi, are you still looking for code reviewers? I'm also interested in reviewing PRs.

[weiznich]

@g-hi3 We are still looking for code reviewers. I've sent you an invitation for the reviewers team. If you join that team you get notifications for each PR where a review is requested. While #3783 is a bit larger it might be a good starting point.
As written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works.

[pppp24]

Hi, would be happy to review some PRs as well if it's still possible to join ? I've got more theoretical knowledge of Rust than practice so would love to get more exposure to it

[weiznich]

@pppp24 I've sent you an invitation for the reviewers team. If you join that team you get notifications for each PR where a review is requested. #3940 might be a good starting PR, although there are some review comments there.
As written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works.

[pppp24]

thanks a lot @weiznich, I notice that #3940 has already been approved but will take a look at it regardless as well as the other recently approved/pending PRs that you requested review on (#3948 , #3949, #3951 )

[peasee]

I'd like to get involved in some reviews as well 😄 I'll help where I can in my spare time!

[weiznich]

@peasee That's really appreciated. I've added you to the relevant team so that you get a notification for PR's that wait for a review. #3951 might be a good starting point.

Also as written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works.

[DavisRayM]

Hi, i'd like to help review PRs; I have beginner level understanding of Rust & would like to contribute/review to get a bit familiar with the language and codebase

[weiznich]

@DavisRayM I've set you an invitation to the reviewer team. If you join that team you get a notification every time a review is requested.diesel-rs/diesel_full_text_search#41 might be a good starting point.

Also as written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works.

[ericbarrionuevo]

I'd be interested in jumpiing into some code reviews about commits in this repository, if you folks are still looking for people, thanks

[weiznich]

@samuelbarrionuevo We are always interested in more reviewers. I've sent you an invitation to relevant team.If you join that team you get a notification every time a review is requested.

#4061 might be a good starting point.

Also as written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works.

[kw217]

Hi @weiznich, I saw the call for reviewers in the Diesel 2.2.0 announcement and I'd love to help. Please could you add me to the team? I'm fairly experienced at Rust and I've used Diesel for a few things over the years. Thanks.

[weiznich]

@kw217 Thanks for your interest. I've sent you an invitation to relevant team.If you join that team you get a notification every time a review is requested.

#4064 might be a good starting point.

[kw217]

Thanks. Belated post-commit review added - LGTM, for what it's worth :-)

[guissalustiano]

Hi, i'd like to help review PRs; I have being helping with some functions and methods implementations and use diesel daily in my job. Thanks!

[weiznich]

@guissalustiano Thanks for your interest. Any help with reviewing PR's is welcome. As written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works.

Any of the recent array function PR's (#4186, #4187, #4190, #4191) is likely a good starting point.

[ndranathunga]

I'd like to get involved in some reviews as well. I'm relatively new to Rust and hoping to learn more by helping.

[cameron1024]

I'd also be keen to help review. Is there a group/mailing list I can be added to?

[weiznich]

@ndranathunga @cameron1024 Thanks for your interest. I've send you both an invitation to join the diesel/reviewer github team. That mostly notifies you if there is a new review requested. Otherwise as written before: Do not hesitate to ask questions about the code you are looking at, even if it seems to be not related to what the PR implements. I will try to answer them and that's a good way to learn more about rust and diesel.

Any of #4202, #4197 or #4169 is likely a good starting point.

[wowinter13]

@weiznich hello there! Could you please add me to the reviewers list?
Also want to have a finger on the pulse of the project :)

[weiznich]

@wowinter13 Thanks for your interest. I've added you as well, otherwise my comment from yesterday still remains accurate, so please to do not hesitate to ask any question that comes up.

[rienmack]

Hi @weiznich wondering if I could help out with some reviews and be added to the reviewers list? Thanks! :)

[weiznich]

@rienmack Additional reviewers are always welcome. I've send you both an invitation to join the diesel/reviewer github team. That mostly notifies you if there is a new review requested. Otherwise as written before: Do not hesitate to ask questions about the code you are looking at, even if it seems to be not related to what the PR implements. I will try to answer them and that's a good way to learn more about rust and diesel.

#4321 might be a good starting point.

[PratikFandade]

Hi @weiznich ! I would love an opportunity to help anyway I can.

[weiznich]

@PratikFandade I've added you to the relevant team. I've send you both an invitation to join the diesel/reviewer github team. That mostly notifies you if there is a new review requested. Otherwise as written before: Do not hesitate to ask questions about the code you are looking at, even if it seems to be not related to what the PR implements. I will try to answer them and that's a good way to learn more about rust and diesel.

diesel-rs/diesel_full_text_search#44 or #4335 might be a good starting point.