Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass size multiples/absolutes as part of procedural generation config #56

Open
honeybunches-of-oates opened this issue Aug 11, 2016 · 9 comments

Comments

@honeybunches-of-oates
Copy link
Collaborator

No description provided.

@chengxuz
Copy link
Collaborator

chengxuz commented Oct 4, 2016

The thing we decide to do now is providing three options to change the size of one object:

  1. There would be a dictionary describing every object's option and size.

Option 1. Relative to a fixed unit length, universal across all scenes.

Option 2. Relative to the size of the room (specified as a fraction of the room)

Option 3. Relative to the object itself (just multiple of the native size).

In all the cases, we would change the longest axis of the object.

@chengxuz
Copy link
Collaborator

chengxuz commented Oct 4, 2016

We might issue a warning or change the input scale if the object seems to be too large to fit in the room.

@chengxuz
Copy link
Collaborator

chengxuz commented Oct 6, 2016

Just finished the Option 3 and committed the changes.
TODO:
README.md also needs to be changed to tell how to use this feature.
Other two options.
Warning about too large scale size.

@yamins81
Copy link
Contributor

yamins81 commented Oct 6, 2016

So let's implement option 1 and update the readme update now, and leave the other option 2 and the warning for later.

@chengxuz
Copy link
Collaborator

chengxuz commented Oct 6, 2016

OK, option 1 and updating the readme has been finished.

@yamins81
Copy link
Contributor

yamins81 commented Oct 6, 2016

Closing, @chengxuz let me know if this issue should be reopened.

@yamins81 yamins81 closed this as completed Oct 6, 2016
@chengxuz
Copy link
Collaborator

chengxuz commented Oct 7, 2016

I am re-opening this issue, as there is one small bug here:

When the permitted list is empty, the current function can not scale the objects. (Thanks for @pbashivan for pointing it out!)

@chengxuz chengxuz reopened this Oct 7, 2016
@chengxuz
Copy link
Collaborator

Bug fixed. Issue closed. Feel free to reopen it if needed.

@chengxuz
Copy link
Collaborator

chengxuz commented Dec 9, 2016

Several other things to do:

  1. Global option about whether adjusting size of every objects to 1 unit
  2. Store size-related information at Mongodb and then make it possible for Unity to use it
    2.1 Size-related information should specify the source of this information (whether canonical size or arbitrary suggestions)
  3. Have the possibility of varying size of instances for same prefabs, sampling from some distribution given by config (or Mongodb)
    3.1 And have the global option to enable it or not whether globally or per-prefab
  4. Be able to adjust size-related information for a group of prefabs, rather than per-prefab

@chengxuz chengxuz reopened this Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants