Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign_csr.py fails on debian stretch with OpenSSL 1.1.0f 25 May 2017 #97

Closed
moosbaue opened this issue Jan 13, 2018 · 2 comments
Closed

Comments

@moosbaue
Copy link

Hi

Thank you for this very useful script.
I recently upgraded to debian stretch from jessie. With my now installed openssl version (1.1.0.f) the script fails. It still works with OpenSSL 1.0.1t on a jessie box

It fails in
line 70: common_name = re.search("Subject:.*? CN=([^\s,;/]+)", out)
because format of CN changed
from CN=([^\s,;/]+)
to CN = ([^\s,;/]+)
the = sign is surrounded by blanks

I do not know if I am the only one with this issue, but changing the regex works for me

Thank you
Josef

@moosbaue
Copy link
Author

I am not very experienced in regex but
common_name = re.search("Subject:.*? CN ?= ?([^\s,;/]+)", out)
handel's both cases

@diafygi
Copy link
Owner

diafygi commented Mar 13, 2018

Are you using an outdated version of sign_csr.py? The current version is CN *= *([^\s,;/]+)

https://github.com/diafygi/acme-nosudo/blob/master/sign_csr.py#L74

@diafygi diafygi closed this as completed Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants