Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't immediately quit when server is unavailable on the a heartbeat #7

Open
dhrp opened this issue Jan 9, 2024 · 1 comment · May be fixed by #14
Open

Don't immediately quit when server is unavailable on the a heartbeat #7

dhrp opened this issue Jan 9, 2024 · 1 comment · May be fixed by #14

Comments

@dhrp
Copy link
Owner

dhrp commented Jan 9, 2024 •
edited
Loading

When the server is shortly unavailable during a heartbeat, the client currently panics and quits. Instead it should retry for up to some time (the task timeout duration) and only then really quit.

This should make server restarts less risky.

Additionally; currently when the heartbeat fails the go process exits, but the subprocess does not. This may ultimately cause the task to be completed twice, unexpectedly. We should either keep trying until the task is successfully marked failed or succeeded..
@dhrp dhrp linked a pull request Jan 12, 2024 that will close this issue
Draft
@Metamess
Copy link

FWIW: Judging from the logs, the moulin server took 3m30s to become available again this morning. This would suggest that a retry window of, say, 5 minutes would have been sufficient (for this morning's specific incident at least)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add retryPolicy stub dhrp/moulin
2 participants
@dhrp @Metamess