Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Androapp 5790 cards design for program stages #3502

Conversation

siddh1004
Copy link
Contributor

Description

This Pr includes the logic update to show/hide grouped and timeline events

jira issue

Solution description

If this PR is a fix include a brief description on how the issue is solved.

Covered unit test cases

Describe the tests that you ran to verify your changes.

Where did you test this issue?

  • Smartphone Emulator
  • Tablet Emulator
  • Smartphone
  • Tablet

Which Android versions did you test this issue?

  • 4.4
  • 5.X - 6.X
  • 7.X
  • 8.X
  • 9.X - 10.X
  • 11.X - 13.X
  • Other

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

Copy link
Collaborator

@andresmr andresmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update branch and solve CI errors

@siddh1004 siddh1004 force-pushed the ANDROAPP-5790-Cards-design-for-program-stages branch 2 times, most recently from e989d44 to ad61234 Compare February 28, 2024 14:48
@siddh1004 siddh1004 requested a review from andresmr February 28, 2024 14:49
@xavimolloy xavimolloy self-requested a review February 28, 2024 15:12
Copy link
Contributor

@xavimolloy xavimolloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it appears some UI tests have failed, can you run them locally to verify that they are not flaky tests, as well as rebase the branch?

@xavimolloy xavimolloy self-requested a review February 29, 2024 07:12
xavimolloy

This comment was marked as duplicate.

@siddh1004 siddh1004 force-pushed the ANDROAPP-5790-Cards-design-for-program-stages branch 2 times, most recently from c22832f to bed87eb Compare March 1, 2024 11:27
@siddh1004 siddh1004 force-pushed the ANDROAPP-5790-Cards-design-for-program-stages branch 2 times, most recently from 7c55159 to 0622720 Compare March 7, 2024 11:12
Copy link

sonarcloud bot commented Mar 7, 2024

@andresmr andresmr merged commit 64b4171 into dhis2:develop Mar 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants