[ANDROAPP-5857] image download implementation #3498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdyrod
reviewed
Feb 14, 2024
Comment on lines
+37
to
+38
| private val fileHandler = FileHandler() | ||
|
|
There was a problem hiding this comment.
Could this class be injected here? Does it make sense to do it?
ferdyrod
reviewed
Feb 14, 2024
Comment on lines
+328
to
+329
| private val fileHandler = FileHandler() | ||
|
|
ferdyrod
reviewed
Feb 14, 2024
Comment on lines
+72
to
+73
| private val fileHandler = FileHandler() | ||
|
|
There was a problem hiding this comment.
My answer is no:
According to the dependency injection definitions:
The intent behind dependency injection is to achieve separation of concerns of construction and use of objects. This can increase readability and code reuse.
So there is no need in injecting every object we use. In this case it is a quite simple class.
ferdyrod
approved these changes
Feb 14, 2024
mmmateos
approved these changes
Feb 14, 2024
Signed-off-by: Pablo <[email protected]>
Signed-off-by: Pablo <[email protected]>
Signed-off-by: Pablo <[email protected]>
Balcan
force-pushed
the
ANDROAPP-5857-Image-download-implementation-on-ImageDetail
branch
from
ae5ac5d to
2a54a0b
Compare
|
Balcan
deleted the
ANDROAPP-5857-Image-download-implementation-on-ImageDetail
branch
Balcan
added a commit
that referenced
this pull request
Apr 29, 2024
* Androapp 5724 remove organization unit in tei event ds card if user only has access to one org unit (#3459) * add logic to show organisation unit organisation unit in TEI list, DataSet and tracker program list will only be shown when user has access to more than one organisation unit. * fix lint error * move `displayOrgUnitName` logic to ui layer --------- Co-authored-by: Siddharth Agarwal <[email protected]> * [ANDROAPP-5887] update SDK (#3471) * feat: [ANDROAPP-5830] update mobile UI version to 0.2-20240103.112017-2 (#3461) * fix: [ANDROAPP-5830] update mobile-ui version 0.2-20240103.112017-2 * feat: [ANDROAPP-5830] add to do's and bare minimun for compilation * ANDROAPP-5829-adapt-input-image-to-new-mobile-ui-functionality (#3462) * Handle `Intent.ACTION_SEND` in form view for sharing files * Open chooser intent when share button is clicked in `ImageInput` * Open chooser intent when share button is clicked in `InputSignature`` * Move `getBitmap` extension to commons module * Move `FormFileProvider` to commons module * Add image detail activity Currently we don't have a working "save image" functionality. So, it didn't make sense to copy the implementation that is not working. So for the time being I marked it as TODO * Launch `ImageDetailActivity` instead of `ImageDetailBottomDialog` * Remove `ImageDetailBottomDialog` * feat: [ANDROAPP-5848] Adapt Input dropdown to new functionality (#3465) * feat: [ANDROAPP-5848] remove old option set dialog, recycler event and deprecated code. refactor OptionSetConfiguration to default adapt input dropdown to new functionality * feat: [ANDROAPP-5848] remove deprecated code * fix: [ANDROAPP-5848] remove deprecated code * fix: [ANDROAPP-5848] ktlint fix * fix: [ANDROAPP-5848] dismiss keyboard on dismiss popup * fix: [ANDROAPP-5848] add old pop in again to maintain old form logic * feat: [ANDROAPP-5848] update mobile ui to version 0.2-20240123.112704-7 * fix: [ANDROAPP-5848] sonar fix * fix: [ANDROAPP-5848] sonar fix --------- Co-authored-by: Sasikanth Miriyampalli <[email protected]> * [ANDROAPP-5891] Implement new signature for compose form and maintain current for old one. (#3475) * feat: [ANDROAPP-5568] hide program stage behavior (#3464) * feat: [ANDROAPP-5523] change error access message at home (#3467) * [Update develop with main] conflict resolution * [Update develop with main] fix test * [Update release notes] Correct typos and delete unnecessary release.info file (#3480) * [ANDROAPP-5760] DashboardRepositoryImpl refactor to kotlin, new test implementation start * Move shouldSuccessfullyCreateANewEvent to unit test * Move shouldNotBeAbleToCreateNewEventsWhenFull to unit tests * Move shouldSuccessfullySyncAChangedTEI to unit tests * fix test Signed-off-by: Pablo <[email protected]> * fix test Signed-off-by: Pablo <[email protected]> * [ANDROAPP-5645] Close enrollment data section if already completed (#3484) --------- Signed-off-by: Pablo <[email protected]> * feat: [ANDROAPP-5683] legend description (#3486) * fix: [ANDROAPP-5900] adapt Input providers to new TextFieldValue usage * fix: [ANDROAPP-5900] update mobile ui 0.2-20240206.071329-16 * fix: [ANDROAPP-5900] set initial selection to value length * updates paging on search to paging3 * update search tests * fix code smells * updates sdk and prevents scroll to top when paginating * Updates sdk * update and adapt design library version * fix tests * adds helpertext to table's input field (#3487) * show confirmation dialog show confirmation dialog before deleting TEI or removing enrolments * show/hide menu items Show TEI Dashboard menu items based on correspondent authorities * update confirm delete dialog design Older BottomSheetDialog has now been replaced by mobile-ui library `BottomSheetSheel` component * Set button color style in delete bottom sheet dialog * Run code formatting * Fix delete button callback not working in `DeleteBottomSheetDialog` * [ANDROAPP-5894] Adapt enrollment label to be configurable from server (#3493) Signed-off-by: Pablo <[email protected]> * Adds a no connection listener to Sync Dialog to show snackbar to users * resolve code smell. now dialog uses SAM interface for the NoConnectionListener * feat: [ANDROAPP-5896] configurable event label (#3495) * cache some complex operations (#3494) Signed-off-by: Pablo <[email protected]> * [ANDROAPP-5857] image download implementation (#3498) * download image files to external directory Signed-off-by: Pablo <[email protected]> * download qr/barcode files to external directory Signed-off-by: Pablo <[email protected]> * show message when file is downloaded Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * feat: [ANDROAPP-5802] schedule events after completion (#3483) * update: [ANDROAPP-4826] design system version updated * add: [ANDROAPP-4826] String added * add: [ANDROAPP-4826] Infobar added, warning message field added * update: [ANDROAPP-4826] visual changes when there is no fields in the section * update: [ANDROAPP-4826] code formatted, visual changes to description * delete: [ANDROAPP-4826] Dummy section deleted in FormSectionMapper * update: [ANDROAPP-4826] the InfoBar doesn't appears when the form is loading * update: [ANDROAPP-4826] libs updated * [ANDROAPP-4826] Show no fields warnings if one section and is NO_HEADER * [ANDROAPP-4826] Refactor section warning generation to mapper * [ANDROAPP-4826] Refactor section warning generation to mapper * [ANDROAPP-5901] Move create button in timeline view (#3490) * [ANDROAPP-5800] Replace xml view by ComposeView * [ANDROAPP-5800] Set up SearchParameter structure * [ANDROAPP-5800] Implement SearchParametersRepository * [ANDROAPP-5800] update search query * [ANDROAPP-500] Remove deprecated steps in walkthrough * [ANDROAPP-500] Implement search and clear button * [ANDROAPP-500] Implement SnackBar for min attributes search * [ANDROAPP-500] Refactor search and clear button to SearchTEIViewModel * [ANDROAPP-500] rebase develop and update library * [ANDROAPP-500] show min attributes message * [ANDROAPP-5800] handle focus * [ANDROAPP-5800] update design library * [ANDROAPP-5800] clear search parameters * [ANDROAPP-5800] Use fieldUiModel for parameter provider * [ANDROAPP-5800] insert inputstyle as parameter * [ANDROAPP-5800] text range to textInput model * [ANDROAPP-5800] update display name values * [ANDROAPP-5800] show org unit selector * [ANDROAPP-5800] remove SearchRepository.kt * [ANDROAPP-5800] fix tests * [ANDROAPP-5800] fix tests * [ANDROAPP-5800] Add composeTestRule to functional tests * [ANDROAPP-5800] Update design library version * [ANDROAPP-5800] Remove SearchParametersRepository.kt and use SearchRepositoryKt * [ANDROAPP-5800] provide icons based on valueType * [ANDROAPP-5800] Implement QR and Barcode scanning * [ANDROAPP-5800] fix code smells * [ANDROAPP-5800] clear focus on clear search * [ANDROAPP-5800] close keyboard om search and clear * [ANDROAPP-5800] close empty fields when clear search * [ANDROAPP-5800] request focus when item is opened * [ANDROAPP-5800] move focus to next item * [ANDROAPP-5800] enable disable search button on empty parameters * [ANDROAPP-5805] clear search button visibility * [ANDROAPP-5805] Adapt top bar when searching * [ANDROAPP-5805] Add replay to mutable search flow in order to emit the first value * [ANDROAPP-5805] Remove connected rounded corners on landscape * [ANDROAPP-5805] update ProgramEventTest to remove check on org unit when is not visible * [ANDROAPP-5800] configure toolbar for landscape * [ANDROAPP-5800] remove unused program variable * [ANDROAPP-5800] remove needs force update parameter from Form only used for search * [ANDROAPP-5800] Remember ScanContract on SearchParametersScreen * [ANDROAPP-5800] Clear focus when closing search * [ANDROAPP-5800] Avoid double updating Age field * [ANDROAPP-5800] Not loop on next click when gets the last item * [ANDROAPP-5800] set rounded corners on show filters landscape * [ANDROAPP-5800] fix code smell * feat: [ANDROAPP-5794] Date Selectors (#3501) * feat: [ANDROAPP-5794] Implement new InputDate Date and TimePicker functionalities * feat: [ANDROAPP-5794] add selectable dates and refactor code * feat: [ANDROAPP-5794] update design system version * feat: [ANDROAPP-5794] update input date in scheduling dialog * feat: [ANDROAPP-5794] adapt new design for implementations with periods * feat: [ANDROAPP-5794] remove old calendar from event details * feat: [ANDROAPP-5794] fix test and add year range control * feat: [ANDROAPP-5794] fix ui test and reformat default values * feat: [ANDROAPP-5794] sonar fix * feat: [ANDROAPP-5794] ktlint * feat: [ANDROAPP-5794] ktlint * feat: [ANDROAPP-5794] update date value on reset button click * fix: [ANDROAPP-5802] scheduling dialog not displayed (#3507) * [ANDROAPP-1540] Multi selection for option set in programs (#3500) Signed-off-by: Pablo <[email protected]> * fix(translations): sync translations from transifex (develop) WARNING: This automated sync from transifex removed more lines than it added. Please check carefully before merging! * fix(translations): sync translations from transifex (develop) * fix: CI fix for new date picker selection (#3511) * fix: CI fix for new date picker selection * fix: readapt to avoid flakiness * fix: remove log printing for datepicker * fix: ignore test * [ANDROAPP-4457] Configurable basemaps (#3509) Signed-off-by: Pablo <[email protected]> * Update ActivityTestRule on SyncActivityTest * Add function to get single tracked entity in `SearchRepositoryKt` * Add `OnQrCodeScannedFormIntent` * Return `OnQrCodeScanned` instead of `OnSave` when QR code is scanned * Update `SearchRepositoryKt#trackedEntity` function to return list of TEIs * Open TEI dashboard when a TEI is found after QR code scanning * Update ActivityTestRule on ProgramEventTest * feat: [ANDROAPP-5919] multiselection on dataset * update design library * Grouped stage events ui logic updated * show all event stages * add toggle button to grouped stage events * update show logic for timeline events * fix code styling * fix toggle button click Earlier when clicking on a particular stage show more buttons, all the stage events were expanding. This commit fixes this. * update toggle button design * update stage item ui * update design for timeline and grouped events * fix lint error * fix roboto test * fix ui test for completed events * fix click for event and stages item * fix `SEARCHTETEST` * fix roboto test * ignore depreciated test * Ignore test WIP * fix sonar test * fix lint error * fix left margin for event card * remove data element value null or empty value * fix text style for stage item title and descr * fix color for skipped element * fix metadata avatar for stage and event item * fix lint error * fix test notation * [ANDROAPP-5941] Use multiplatform rule engine (#3505) * Rename .java to .kt Signed-off-by: Pablo <[email protected]> * update rule engine Signed-off-by: Pablo <[email protected]> * update rule engine Signed-off-by: Pablo <[email protected]> * Rename .java to .kt Signed-off-by: Pablo <[email protected]> * use multiplatform rule engine Signed-off-by: Pablo <[email protected]> * rule engine module Signed-off-by: Pablo <[email protected]> * set null enrollment uid Signed-off-by: Pablo <[email protected]> * fix dagger Signed-off-by: Pablo <[email protected]> * fix tests Signed-off-by: Pablo <[email protected]> * fix LMIS test Signed-off-by: Pablo <[email protected]> * ktlint Signed-off-by: Pablo <[email protected]> * fix tests Signed-off-by: Pablo <[email protected]> * add desugar lib Signed-off-by: Pablo <[email protected]> * removed unused test Signed-off-by: Pablo <[email protected]> * fix code smells Signed-off-by: Pablo <[email protected]> * remove duplicated dependencies Signed-off-by: Pablo <[email protected]> * fix displayText Signed-off-by: Pablo <[email protected]> * fix test Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * [ANDROAPP-2474] Import/Export database (#3503) Signed-off-by: Pablo <[email protected]> * fix(translations): sync translations from transifex (develop) * fix FormTest (#3523) * fix FormTest Signed-off-by: Pablo <[email protected]> * remove commented code Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * Set compose forms as default * verifying signed commit * fix: [ANDROAPP-5802] scheduling program stages (#3518) * fix: [ANDROAPP-5802] scheduling program stages * fix: [ANDROAPP-5802] scheduling program stages * fix black screen when qr is read (#3524) Signed-off-by: Pablo <[email protected]> * Update SearchTETest (#3525) * Update SearchTETest with lazyActivityScenario and composeTestRule * fix shouldShowErrorWhenSyncEventFails * revert Jenkinsfile changes * shouldShowErrorWhenSyncEventFails click on event item * feat: [ANDROAPP-5930] move details information to the registration form (#3512) * feat: [ANDROAPP-5930] Initial commit: move enrollement date to formulary, check org unit open/close dates, modify enrollment screen * feat: [ANDROAPP-5930] update allowed dates based on selected Org Unit correctly * feat: [ANDROAPP-5930] remove unnecessary code and comments * feat: [ANDROAPP-5930] amend sonar fix for failed test * feat: [ANDROAPP-5930] correct flaky test and adapt to new enrollment flow * feat: [ANDROAPP-5930] readapt instrumentation tests to new enrollment flow * fix: [ANDROAPP-5930] sonar fix * fix: [ANDROAPP-5930] format style and add Unit tests for EnrollmentRepository class * fix: [ANDROAPP-5800] search page corrections (#3517) * fix: [ANDROAPP-5800] filter by equals instead of contains if parameter is option set, order search params * fix: [ANDROAPP-5800] correct value change when switching between age, month year inputs * fix: [ANDROAPP-5800] lint check * [ANDROAPP-5911] Fix paging3 mapping (#3526) Co-authored-by: Manu Muñoz <[email protected]> Signed-off-by: Pablo <[email protected]> * [ANDROAPP-5123] Support for custom icons (#3510) Co-authored-by: Manu Muñoz <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * [ANDROAPP-5309] Line listing in local analytics (#3516) Signed-off-by: Pablo <[email protected]> Co-authored-by: manu <[email protected]> * fix: [ANDROAPP-5976] crash after discard or delete event (#3533) * feat: [ANDROAPP-5952] Update design system and adapt InputAge to new … (#3531) * feat: [ANDROAPP-5952] Update design system and adapt InputAge to new implementation, add tests for component * fix: [ANDROAPP-5952] take timezone into account for date setting * fix: [ANDROAPP-5952] code clean up * fix: [ANDROAPP-5952] update design system * fix: [ANDROAPP-5952] fix test * Androapp 5996 error in timeline view when there are no events created (#3527) * fix groupByStage value set method * fix timeline events recycler view when no events * fix the event count in timeline header * revert get grouping change --------- Co-authored-by: Siddharth Agarwal <[email protected]> * fix: [ANDROAPP-5988] crash when returning to dashboard event list (#3540) * fix feedback on delete program enrollments (#3537) * fix feedback on delete program enrollments * fix lint error --------- Co-authored-by: Siddharth Agarwal <[email protected]> * fix event card item margins (#3536) * fix event card item margins * fix lint error --------- Co-authored-by: Siddharth Agarwal <[email protected]> * ANDROAPP-5799-search-enroll-button (#3535) * Load TE type name when search view model is created * Use new FAB component for `CreateNewButton` * Update search button UI * Add old search button composable * Remove `SearchTEListScreen.kt` * Add `Add new $teType` button * Rename `SearchButton_Old` to `SearchButtonWithQuery` * Show create TEI FAB if there is query data * Display old search button when there is search query data * Use `CoordinatorLayout` in `fragment_search_list` layout Rather than listening to scroll state changes manually, we can just leverage the inbuilt scroll behaviour of coordinator which is smoother. We are using a fake appbar to wrap the header content essentially. * Remove animated visibility from `FullSearchButtonAndWorkingList` * Use immutable map in `FullSearchButtonAndWorkingList` composable * Update design of search bar with query data * Show search bar with query data and create new entity button in landscape * Add icon to search button * Use lower case TE type name in the create button * Update working list chip group spacing * fix: [ANDROAPP-5982] "All [TE Type]" search and relationship search crash (#3542) * [ANDROAPP-5123] Do not use app MetadataIcon (#3539) * refactor custom icons Signed-off-by: Pablo <[email protected]> * fix program metadata icon Signed-off-by: Pablo <[email protected]> * fix tests Signed-off-by: Pablo <[email protected]> * fix eventi Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * [ANDROAPP-5309] fix table dimensions (#3541) * fix table dimensions Signed-off-by: Pablo <[email protected]> * design comments Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> Co-authored-by: Andrés Miguel Rubio <[email protected]> * fix: [ANDROAPP-5930] remove old unnecessary header and modify edit en… (#3538) * fix: [ANDROAPP-5930] remove old unnecessary header and modify edit enrollment corners and header * fix: [ANDROAPP-5930] wait for idle in test * fix: [ANDROAPP-5930] refactor methods * [ANDROAPP-5952] input age prompt stays at beginning (#3543) * refactor custom icons Signed-off-by: Pablo <[email protected]> * fix: [ANDROAPP-5930] update design system and adapt input for textfieldValue * fix: [ANDROAPP-5930] add null checks for value format * fix: [ANDROAPP-5952] correct test * fix: [ANDROAPP-5952] amend rebase conflic resolution update design system --------- Signed-off-by: Pablo <[email protected]> Co-authored-by: Pablo <[email protected]> * [ANDROAPP-5805] Move details information to Event Data entry (#3528) * [ANDROAPP-5805] Simplify if else on EventDate * [ANDROAPP-5805] Remove MviIntent interface * [ANDROAPP-5805] Remove nullable parameters forced by using search * [ANDROAPP-5805] Add Event details section with report date * [ANDROAPP-5805] Add Event Org unit in details * [ANDROAPP-5805] Add Event Coordinates in details * [ANDROAPP-5805] Add Event Category Combo in details * [ANDROAPP-5805] Create Eventwithout registration and navigate to Dataentry * [ANDROAPP-5805] Add CreateEventUseCase * [ANDROAPP-5805] update saving attribute option combo * [ANDROAPP-5805] move PeriodUtils to common * [ANDROAPP-5805] Implement period selector for events * [ANDROAPP-5805] Set EventMode and allow org unit edition on creation * [ANDROAPP-5805] Add eventCatCombo parameter to equals method in FieldUiModelImpl * [ANDROAPP-5805] Remove Event Detail section * [ANDROAPP-5805] Remove date on CreateEventUseCase * [ANDROAPP-5805] load selected category option combo * [ANDROAPP-5805] fix test dependencies * [ANDROAPP-5805] fix ProgramEventTest * [ANDROAPP-5805] fix EventTest * [ANDROAPP-5805] ktlintFormat after rebasing custom icons * [ANDROAPP-5805] Add editable reason to EventCaptureForm * [ANDROAPP-5931] Collapse event details and cat combo sections if completed (#3530) Signed-off-by: Pablo <[email protected]> * [ANDROAPP-5805] fix collapsible when no coordinates * [ANDROAPP-5805] Fix ProgramEventTest * [ANDROAPP-5805] Fix FormTest * [ANDROAPP-5805] Fix EventTest * [ANDROAPP-5805] Fix ProgramEventTest * [ANDROAPP-5805] Add idlingResource to EventCaptureFormPresenter * [ANDROAPP-5805] Handle remove org unit when creating event * [ANDROAPP-5805] Handle adding cat combo * [ANDROAPP-5805] Handle adding cat combo * [ANDROAPP-5805] fix code smells * [ANDROAPP-5805] fix code smells --------- Signed-off-by: Pablo <[email protected]> Co-authored-by: Pablo <[email protected]> * Change start padding of event item when grouped (#3546) * Update android sdk 1.10.0 snapshot 36 (#3547) * fix: [ANDROAPP-5923] All enrollment screen crash (#3534) * prevents crash on All enrollments screen * removes deleted view tags from test * removes useless non-null access * Add idilingResource to event tests (#3550) * Update release start job (#3549) * release_start workflow * Update release-start.yml --------- Co-authored-by: manu <[email protected]> * Update version to 2.10 * fix: [ANDROAPP-6003] multiselection checked values (#3545) * fix: [ANDROAPP-5981] the app crashes randomly when scheduling new events in tracker program (#3521) * fix: [ANDROAPP-5981] filter by distinct events when updating to avoid duplicate calls to same event * fix: [ANDROAPP-5981] remove unnecessary subscription to observer, remove NonNullAsserted !! assertions for option codes and org unit codes * fix: [ANDROAPP-5981] code smells and small refactor * fix: [ANDROAPP-5981] update with requested changes * fix: [ANDROAPP-5981] ignore flaky test * [ANDROAPP-6010] defect event details catcombo scope fails when modifying org unit (#3555) * [ANDROAPP-6010] Adapt Event toolbar to new design * [ANDROAPP-6010] Set ProgramCaptureScope to event orgunit * [ANDROAPP-6010] check category combos for mandatory fields * fix: [ANDROAPP-6006] update changes on dashboard (#3554) * Add IdlingResource when completing an event (#3556) * Update android sdk 1.10.0 snapshot 37 (#3560) Co-authored-by: Andrés Miguel Rubio <[email protected]> * fix icon size and alignment of program stage item (#3552) Co-authored-by: Siddharth Agarwal <[email protected]> * fi: [ANDROAPP-6004] All {TE Type} search now show too many result. (#3553) * Update android sdk 1.10.0 snapshot 38 (#3562) * Update android sdk 1.10.0 snapshot 38 * Adapt unit tests * fix: [ANDROAPP-6017] only searched fields on searched bar (#3559) * update desyng system (#3544) Signed-off-by: Pablo <[email protected]> * add anr reports in sentry (#3532) Signed-off-by: Pablo <[email protected]> * [ANDROAPP-6007] Use default color in metadata icons (#3557) * use default color Signed-off-by: Pablo <[email protected]> * fix unit tests Signed-off-by: Pablo <[email protected]> * remove unused Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * fix: [ANDROAPP-6024] table resize dimensions (#3566) * [ANDROAPP-6023] Scheduled event missbehavior (#3565) * [ANDROAPP-6023] Remove Event initial step when scheduling and event * [ANDROAPP-6023] add event form aesthetics rounded corners * [ANDROAPP-6023] set entollment from schedule and by generation after create an enrollment as new events. * [ANDROAPP-6023] Set EventMode Schedule when entering data scheduling an event * [ANDROAPP-6023] Remove unused EventCaptureInitial package * [ANDROAPP-6023] Change Enter/Cancel button text by Enter/Skip * [ANDROAPP-6023] Set rounded corners on EventCaptureActivity sections * fix: [ANDROAPP-6008] user-friendly name on search parameters (#3563) * updates Dashboard only when new tei dashboard card is shown (#3567) * fix: [ANDROAPP-6013] don't save events without date or catCombo (#3569) * fix: [ANDROAPP-6040] Remove scroll to first empty item functionality (#3571) * fix: [ANDROAPP-6040] Remove scroll to first empty item functionality * fix: [ANDROAPP-6040] adapt test now that automatic scroll does not occur * [Androapp-5763] cropped number when data element name wraps into second line (#3570) * feat: [ANDROAPP-5763] implement Indicator Input throughout app * [ANDROAPP-5763] Use biggerOrEquals for filtering legends Signed-off-by: andresmr <[email protected]> * [ANDROAPP-5763] Set SurfaceColor.Container as default color Signed-off-by: andresmr <[email protected]> * [ANDROAPP-5763] Remove xml from IndicatorViewHolder Signed-off-by: andresmr <[email protected]> * [ANDROAPP-5763] Replace test robots Signed-off-by: andresmr <[email protected]> * [ANDROAPP-5763] Remove uncommented test code Signed-off-by: andresmr <[email protected]> * [ANDROAPP-5763] Move spacing to vertical arrangement Signed-off-by: andresmr <[email protected]> --------- Signed-off-by: andresmr <[email protected]> Co-authored-by: Xavier Molloy <[email protected]> * fix: [ANDROAPP-6038] improved management for Cancel event in OU dialog (#3572) * fix: [ANDROAPP-6038] enable add new button when exiting canceling OU dialog * fix: [ANDROAPP-6038] small code refactor * Update design library to 0.2-20240405.110637-52 (#3575) Signed-off-by: andresmr <[email protected]> * [ANDROAPP-6086] set today es event date when creating new event (#3577) Signed-off-by: andresmr <[email protected]> * fix: [ANDROAPP-6033] modify padding between ListCard components, add superior padding if item is first one in order to improve superior border visibility (#3568) * fix: [ANDROAPP-6011] freeze getting dashboard events (#3574) * fix: [ANDROAPP-6011] freeze getting dashboard events * fix test * fix test * access localdatastore in background thread (#3580) Signed-off-by: Pablo <[email protected]> * Create build-release-candidate.yml (#3573) * Create build-release-candidate.yml * Update build-release-candidate.yml * buid release candidate signing config Signed-off-by: Pablo <[email protected]> * set keystore path Signed-off-by: Pablo <[email protected]> * set missing env variables Signed-off-by: Pablo <[email protected]> * ktlint Signed-off-by: Pablo <[email protected]> * ignore schedule event test --------- Signed-off-by: Pablo <[email protected]> Co-authored-by: manu <[email protected]> * [ANDROAPP-6015] update design system (#3585) Signed-off-by: andresmr <[email protected]> * fix: [ANDROAPP-6091] days to scheduled day (#3578) * update version name (#3584) * fix: [ANDROAPP-6053] ANR on dataset list (#3583) * [ANDROAPP-5712] Update sync dialog when reopened (#3564) * Update sync dialog when reopened Signed-off-by: Pablo <[email protected]> * wait for compose to idle Signed-off-by: Pablo <[email protected]> * use indeterminate progress in granular sync Signed-off-by: Pablo <[email protected]> * wait for the data to be loaded Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * Get period step on background (#3582) Signed-off-by: Pablo <[email protected]> * fix: [ANDROAPP-6110] crash in program default metadata icon (#3594) * fix: Improve performance in home and event program screen (analytics tab) (#3595) * Improve performance in home screen (analytics tab) * Improve performance in program event screen (analytics tab) * Refactor condition * Restore deleted code * fix: [ANDROAPP-6103] month value in scheduling dialog (#3590) * fix component focus requester (#3587) Co-authored-by: Siddharth Agarwal <[email protected]> * [ANDROAPP-6106] Replace enrollment label with custom one (#3592) * replace enrollment label with custom one Signed-off-by: Pablo <[email protected]> * replace enrollment label with custom one in complete dialog Signed-off-by: Pablo <[email protected]> * Restore enrollment list label Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * Fix IndexOutOfBounds exception in SyncStat (#3597) Signed-off-by: Pablo <[email protected]> * fix: [ANDROAPP-5992] check program stage filters in WorkingListScope (#3600) * fix: [ANDROAPP-5992] check program stage filters in WorkingListScope * fix: [ANDROAPP-5992] check program stage filters in WorkingListScope * [ANDROAPP-6012] Display validation errors (#3599) * [ANDROAPP-6012] Display validation errors Signed-off-by: Pablo <[email protected]> * apply validation only for date value dates Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * Skip OU selection for single option in event creation (#3588) * skip OU selection when count is 1 * fix lint error * Fix nullable programUid for OURepository * Fix TEIPresenter Test * Code refactored:move functions to repository class * Fix lint error --------- Co-authored-by: Siddharth Agarwal <[email protected]> * fix: [ANDROAPP-6081] set current date for new enrollment (#3603) * [ANDROAPP-5949] OpenID login button overlaps with "Manage accounts" (#3606) Signed-off-by: Pablo <[email protected]> * fix: [ANDROAPP-6119] verify array size before accessing index (#3602) Co-authored-by: Xavier Molloy <[email protected]> * [ANDROAPP-5787] Use search scope in a referral (#3608) * [ANDROAPP-5787] Use search scope in a referral Signed-off-by: Pablo <[email protected]> * [ANDROAPP-5787] add test Signed-off-by: Pablo <[email protected]> * search scope must return search and capture org units Signed-off-by: Pablo <[email protected]> * search scope must return search and capture org units Signed-off-by: Pablo <[email protected]> * fix test Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * browserstack build tag (#3610) * fix: [ANDROAPP-6123] key text in list cards (#3614) Co-authored-by: DavidAparicioAlbaAsenjo <[email protected]> * [ANDROAPP-5869] Provide different keys for fixedStickyHeader (#3607) Signed-off-by: Pablo <[email protected]> * fix: [ANDROAPP-5883] periods when orgunit is closed (#3613) * [ANDROAPP-5757] Field with error can't be disabled (#3609) Signed-off-by: Pablo <[email protected]> * [ANDROAPP-6126] Date parse exception when searching by unfinished date string (#3604) Signed-off-by: Pablo <[email protected]> * fix: [ANDROAPP-6062] clear search fields when required attributes to search (#3581) * fix: [ANDROAPP-6062] clear search fields when required attributes to search * add clear test --------- Signed-off-by: Pablo <[email protected]> Signed-off-by: andresmr <[email protected]> Co-authored-by: Siddharth Agarwal <[email protected]> Co-authored-by: Siddharth Agarwal <[email protected]> Co-authored-by: Andrés Miguel Rubio <[email protected]> Co-authored-by: Xavier Molloy <[email protected]> Co-authored-by: Sasikanth Miriyampalli <[email protected]> Co-authored-by: Manu Muñoz <[email protected]> Co-authored-by: Xavier Molloy <[email protected]> Co-authored-by: FerdyRod <[email protected]> Co-authored-by: = <[email protected]> Co-authored-by: dhis2-bot <[email protected]> Co-authored-by: manu <[email protected]> Co-authored-by: FerdyRod <[email protected]> Co-authored-by: Víctor García <[email protected]> Co-authored-by: GitHub Actions Bot <[email protected]> Co-authored-by: DavidAparicioAlbaAsenjo <[email protected]>
andresmr
added a commit
that referenced
this pull request
Apr 30, 2024
* Create publish-libraries.yml * Create build-release-candidate.yml * Update build-release-candidate.yml * Update mobile-ui library version to 0.1-SNAPSHOT (#3579) Signed-off-by: andresmr <[email protected]> * Release/2.10 (#3611) * Androapp 5724 remove organization unit in tei event ds card if user only has access to one org unit (#3459) * add logic to show organisation unit organisation unit in TEI list, DataSet and tracker program list will only be shown when user has access to more than one organisation unit. * fix lint error * move `displayOrgUnitName` logic to ui layer --------- Co-authored-by: Siddharth Agarwal <[email protected]> * [ANDROAPP-5887] update SDK (#3471) * feat: [ANDROAPP-5830] update mobile UI version to 0.2-20240103.112017-2 (#3461) * fix: [ANDROAPP-5830] update mobile-ui version 0.2-20240103.112017-2 * feat: [ANDROAPP-5830] add to do's and bare minimun for compilation * ANDROAPP-5829-adapt-input-image-to-new-mobile-ui-functionality (#3462) * Handle `Intent.ACTION_SEND` in form view for sharing files * Open chooser intent when share button is clicked in `ImageInput` * Open chooser intent when share button is clicked in `InputSignature`` * Move `getBitmap` extension to commons module * Move `FormFileProvider` to commons module * Add image detail activity Currently we don't have a working "save image" functionality. So, it didn't make sense to copy the implementation that is not working. So for the time being I marked it as TODO * Launch `ImageDetailActivity` instead of `ImageDetailBottomDialog` * Remove `ImageDetailBottomDialog` * feat: [ANDROAPP-5848] Adapt Input dropdown to new functionality (#3465) * feat: [ANDROAPP-5848] remove old option set dialog, recycler event and deprecated code. refactor OptionSetConfiguration to default adapt input dropdown to new functionality * feat: [ANDROAPP-5848] remove deprecated code * fix: [ANDROAPP-5848] remove deprecated code * fix: [ANDROAPP-5848] ktlint fix * fix: [ANDROAPP-5848] dismiss keyboard on dismiss popup * fix: [ANDROAPP-5848] add old pop in again to maintain old form logic * feat: [ANDROAPP-5848] update mobile ui to version 0.2-20240123.112704-7 * fix: [ANDROAPP-5848] sonar fix * fix: [ANDROAPP-5848] sonar fix --------- Co-authored-by: Sasikanth Miriyampalli <[email protected]> * [ANDROAPP-5891] Implement new signature for compose form and maintain current for old one. (#3475) * feat: [ANDROAPP-5568] hide program stage behavior (#3464) * feat: [ANDROAPP-5523] change error access message at home (#3467) * [Update develop with main] conflict resolution * [Update develop with main] fix test * [Update release notes] Correct typos and delete unnecessary release.info file (#3480) * [ANDROAPP-5760] DashboardRepositoryImpl refactor to kotlin, new test implementation start * Move shouldSuccessfullyCreateANewEvent to unit test * Move shouldNotBeAbleToCreateNewEventsWhenFull to unit tests * Move shouldSuccessfullySyncAChangedTEI to unit tests * fix test Signed-off-by: Pablo <[email protected]> * fix test Signed-off-by: Pablo <[email protected]> * [ANDROAPP-5645] Close enrollment data section if already completed (#3484) --------- Signed-off-by: Pablo <[email protected]> * feat: [ANDROAPP-5683] legend description (#3486) * fix: [ANDROAPP-5900] adapt Input providers to new TextFieldValue usage * fix: [ANDROAPP-5900] update mobile ui 0.2-20240206.071329-16 * fix: [ANDROAPP-5900] set initial selection to value length * updates paging on search to paging3 * update search tests * fix code smells * updates sdk and prevents scroll to top when paginating * Updates sdk * update and adapt design library version * fix tests * adds helpertext to table's input field (#3487) * show confirmation dialog show confirmation dialog before deleting TEI or removing enrolments * show/hide menu items Show TEI Dashboard menu items based on correspondent authorities * update confirm delete dialog design Older BottomSheetDialog has now been replaced by mobile-ui library `BottomSheetSheel` component * Set button color style in delete bottom sheet dialog * Run code formatting * Fix delete button callback not working in `DeleteBottomSheetDialog` * [ANDROAPP-5894] Adapt enrollment label to be configurable from server (#3493) Signed-off-by: Pablo <[email protected]> * Adds a no connection listener to Sync Dialog to show snackbar to users * resolve code smell. now dialog uses SAM interface for the NoConnectionListener * feat: [ANDROAPP-5896] configurable event label (#3495) * cache some complex operations (#3494) Signed-off-by: Pablo <[email protected]> * [ANDROAPP-5857] image download implementation (#3498) * download image files to external directory Signed-off-by: Pablo <[email protected]> * download qr/barcode files to external directory Signed-off-by: Pablo <[email protected]> * show message when file is downloaded Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * feat: [ANDROAPP-5802] schedule events after completion (#3483) * update: [ANDROAPP-4826] design system version updated * add: [ANDROAPP-4826] String added * add: [ANDROAPP-4826] Infobar added, warning message field added * update: [ANDROAPP-4826] visual changes when there is no fields in the section * update: [ANDROAPP-4826] code formatted, visual changes to description * delete: [ANDROAPP-4826] Dummy section deleted in FormSectionMapper * update: [ANDROAPP-4826] the InfoBar doesn't appears when the form is loading * update: [ANDROAPP-4826] libs updated * [ANDROAPP-4826] Show no fields warnings if one section and is NO_HEADER * [ANDROAPP-4826] Refactor section warning generation to mapper * [ANDROAPP-4826] Refactor section warning generation to mapper * [ANDROAPP-5901] Move create button in timeline view (#3490) * [ANDROAPP-5800] Replace xml view by ComposeView * [ANDROAPP-5800] Set up SearchParameter structure * [ANDROAPP-5800] Implement SearchParametersRepository * [ANDROAPP-5800] update search query * [ANDROAPP-500] Remove deprecated steps in walkthrough * [ANDROAPP-500] Implement search and clear button * [ANDROAPP-500] Implement SnackBar for min attributes search * [ANDROAPP-500] Refactor search and clear button to SearchTEIViewModel * [ANDROAPP-500] rebase develop and update library * [ANDROAPP-500] show min attributes message * [ANDROAPP-5800] handle focus * [ANDROAPP-5800] update design library * [ANDROAPP-5800] clear search parameters * [ANDROAPP-5800] Use fieldUiModel for parameter provider * [ANDROAPP-5800] insert inputstyle as parameter * [ANDROAPP-5800] text range to textInput model * [ANDROAPP-5800] update display name values * [ANDROAPP-5800] show org unit selector * [ANDROAPP-5800] remove SearchRepository.kt * [ANDROAPP-5800] fix tests * [ANDROAPP-5800] fix tests * [ANDROAPP-5800] Add composeTestRule to functional tests * [ANDROAPP-5800] Update design library version * [ANDROAPP-5800] Remove SearchParametersRepository.kt and use SearchRepositoryKt * [ANDROAPP-5800] provide icons based on valueType * [ANDROAPP-5800] Implement QR and Barcode scanning * [ANDROAPP-5800] fix code smells * [ANDROAPP-5800] clear focus on clear search * [ANDROAPP-5800] close keyboard om search and clear * [ANDROAPP-5800] close empty fields when clear search * [ANDROAPP-5800] request focus when item is opened * [ANDROAPP-5800] move focus to next item * [ANDROAPP-5800] enable disable search button on empty parameters * [ANDROAPP-5805] clear search button visibility * [ANDROAPP-5805] Adapt top bar when searching * [ANDROAPP-5805] Add replay to mutable search flow in order to emit the first value * [ANDROAPP-5805] Remove connected rounded corners on landscape * [ANDROAPP-5805] update ProgramEventTest to remove check on org unit when is not visible * [ANDROAPP-5800] configure toolbar for landscape * [ANDROAPP-5800] remove unused program variable * [ANDROAPP-5800] remove needs force update parameter from Form only used for search * [ANDROAPP-5800] Remember ScanContract on SearchParametersScreen * [ANDROAPP-5800] Clear focus when closing search * [ANDROAPP-5800] Avoid double updating Age field * [ANDROAPP-5800] Not loop on next click when gets the last item * [ANDROAPP-5800] set rounded corners on show filters landscape * [ANDROAPP-5800] fix code smell * feat: [ANDROAPP-5794] Date Selectors (#3501) * feat: [ANDROAPP-5794] Implement new InputDate Date and TimePicker functionalities * feat: [ANDROAPP-5794] add selectable dates and refactor code * feat: [ANDROAPP-5794] update design system version * feat: [ANDROAPP-5794] update input date in scheduling dialog * feat: [ANDROAPP-5794] adapt new design for implementations with periods * feat: [ANDROAPP-5794] remove old calendar from event details * feat: [ANDROAPP-5794] fix test and add year range control * feat: [ANDROAPP-5794] fix ui test and reformat default values * feat: [ANDROAPP-5794] sonar fix * feat: [ANDROAPP-5794] ktlint * feat: [ANDROAPP-5794] ktlint * feat: [ANDROAPP-5794] update date value on reset button click * fix: [ANDROAPP-5802] scheduling dialog not displayed (#3507) * [ANDROAPP-1540] Multi selection for option set in programs (#3500) Signed-off-by: Pablo <[email protected]> * fix(translations): sync translations from transifex (develop) WARNING: This automated sync from transifex removed more lines than it added. Please check carefully before merging! * fix(translations): sync translations from transifex (develop) * fix: CI fix for new date picker selection (#3511) * fix: CI fix for new date picker selection * fix: readapt to avoid flakiness * fix: remove log printing for datepicker * fix: ignore test * [ANDROAPP-4457] Configurable basemaps (#3509) Signed-off-by: Pablo <[email protected]> * Update ActivityTestRule on SyncActivityTest * Add function to get single tracked entity in `SearchRepositoryKt` * Add `OnQrCodeScannedFormIntent` * Return `OnQrCodeScanned` instead of `OnSave` when QR code is scanned * Update `SearchRepositoryKt#trackedEntity` function to return list of TEIs * Open TEI dashboard when a TEI is found after QR code scanning * Update ActivityTestRule on ProgramEventTest * feat: [ANDROAPP-5919] multiselection on dataset * update design library * Grouped stage events ui logic updated * show all event stages * add toggle button to grouped stage events * update show logic for timeline events * fix code styling * fix toggle button click Earlier when clicking on a particular stage show more buttons, all the stage events were expanding. This commit fixes this. * update toggle button design * update stage item ui * update design for timeline and grouped events * fix lint error * fix roboto test * fix ui test for completed events * fix click for event and stages item * fix `SEARCHTETEST` * fix roboto test * ignore depreciated test * Ignore test WIP * fix sonar test * fix lint error * fix left margin for event card * remove data element value null or empty value * fix text style for stage item title and descr * fix color for skipped element * fix metadata avatar for stage and event item * fix lint error * fix test notation * [ANDROAPP-5941] Use multiplatform rule engine (#3505) * Rename .java to .kt Signed-off-by: Pablo <[email protected]> * update rule engine Signed-off-by: Pablo <[email protected]> * update rule engine Signed-off-by: Pablo <[email protected]> * Rename .java to .kt Signed-off-by: Pablo <[email protected]> * use multiplatform rule engine Signed-off-by: Pablo <[email protected]> * rule engine module Signed-off-by: Pablo <[email protected]> * set null enrollment uid Signed-off-by: Pablo <[email protected]> * fix dagger Signed-off-by: Pablo <[email protected]> * fix tests Signed-off-by: Pablo <[email protected]> * fix LMIS test Signed-off-by: Pablo <[email protected]> * ktlint Signed-off-by: Pablo <[email protected]> * fix tests Signed-off-by: Pablo <[email protected]> * add desugar lib Signed-off-by: Pablo <[email protected]> * removed unused test Signed-off-by: Pablo <[email protected]> * fix code smells Signed-off-by: Pablo <[email protected]> * remove duplicated dependencies Signed-off-by: Pablo <[email protected]> * fix displayText Signed-off-by: Pablo <[email protected]> * fix test Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * [ANDROAPP-2474] Import/Export database (#3503) Signed-off-by: Pablo <[email protected]> * fix(translations): sync translations from transifex (develop) * fix FormTest (#3523) * fix FormTest Signed-off-by: Pablo <[email protected]> * remove commented code Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * Set compose forms as default * verifying signed commit * fix: [ANDROAPP-5802] scheduling program stages (#3518) * fix: [ANDROAPP-5802] scheduling program stages * fix: [ANDROAPP-5802] scheduling program stages * fix black screen when qr is read (#3524) Signed-off-by: Pablo <[email protected]> * Update SearchTETest (#3525) * Update SearchTETest with lazyActivityScenario and composeTestRule * fix shouldShowErrorWhenSyncEventFails * revert Jenkinsfile changes * shouldShowErrorWhenSyncEventFails click on event item * feat: [ANDROAPP-5930] move details information to the registration form (#3512) * feat: [ANDROAPP-5930] Initial commit: move enrollement date to formulary, check org unit open/close dates, modify enrollment screen * feat: [ANDROAPP-5930] update allowed dates based on selected Org Unit correctly * feat: [ANDROAPP-5930] remove unnecessary code and comments * feat: [ANDROAPP-5930] amend sonar fix for failed test * feat: [ANDROAPP-5930] correct flaky test and adapt to new enrollment flow * feat: [ANDROAPP-5930] readapt instrumentation tests to new enrollment flow * fix: [ANDROAPP-5930] sonar fix * fix: [ANDROAPP-5930] format style and add Unit tests for EnrollmentRepository class * fix: [ANDROAPP-5800] search page corrections (#3517) * fix: [ANDROAPP-5800] filter by equals instead of contains if parameter is option set, order search params * fix: [ANDROAPP-5800] correct value change when switching between age, month year inputs * fix: [ANDROAPP-5800] lint check * [ANDROAPP-5911] Fix paging3 mapping (#3526) Co-authored-by: Manu Muñoz <[email protected]> Signed-off-by: Pablo <[email protected]> * [ANDROAPP-5123] Support for custom icons (#3510) Co-authored-by: Manu Muñoz <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * [ANDROAPP-5309] Line listing in local analytics (#3516) Signed-off-by: Pablo <[email protected]> Co-authored-by: manu <[email protected]> * fix: [ANDROAPP-5976] crash after discard or delete event (#3533) * feat: [ANDROAPP-5952] Update design system and adapt InputAge to new … (#3531) * feat: [ANDROAPP-5952] Update design system and adapt InputAge to new implementation, add tests for component * fix: [ANDROAPP-5952] take timezone into account for date setting * fix: [ANDROAPP-5952] code clean up * fix: [ANDROAPP-5952] update design system * fix: [ANDROAPP-5952] fix test * Androapp 5996 error in timeline view when there are no events created (#3527) * fix groupByStage value set method * fix timeline events recycler view when no events * fix the event count in timeline header * revert get grouping change --------- Co-authored-by: Siddharth Agarwal <[email protected]> * fix: [ANDROAPP-5988] crash when returning to dashboard event list (#3540) * fix feedback on delete program enrollments (#3537) * fix feedback on delete program enrollments * fix lint error --------- Co-authored-by: Siddharth Agarwal <[email protected]> * fix event card item margins (#3536) * fix event card item margins * fix lint error --------- Co-authored-by: Siddharth Agarwal <[email protected]> * ANDROAPP-5799-search-enroll-button (#3535) * Load TE type name when search view model is created * Use new FAB component for `CreateNewButton` * Update search button UI * Add old search button composable * Remove `SearchTEListScreen.kt` * Add `Add new $teType` button * Rename `SearchButton_Old` to `SearchButtonWithQuery` * Show create TEI FAB if there is query data * Display old search button when there is search query data * Use `CoordinatorLayout` in `fragment_search_list` layout Rather than listening to scroll state changes manually, we can just leverage the inbuilt scroll behaviour of coordinator which is smoother. We are using a fake appbar to wrap the header content essentially. * Remove animated visibility from `FullSearchButtonAndWorkingList` * Use immutable map in `FullSearchButtonAndWorkingList` composable * Update design of search bar with query data * Show search bar with query data and create new entity button in landscape * Add icon to search button * Use lower case TE type name in the create button * Update working list chip group spacing * fix: [ANDROAPP-5982] "All [TE Type]" search and relationship search crash (#3542) * [ANDROAPP-5123] Do not use app MetadataIcon (#3539) * refactor custom icons Signed-off-by: Pablo <[email protected]> * fix program metadata icon Signed-off-by: Pablo <[email protected]> * fix tests Signed-off-by: Pablo <[email protected]> * fix eventi Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * [ANDROAPP-5309] fix table dimensions (#3541) * fix table dimensions Signed-off-by: Pablo <[email protected]> * design comments Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> Co-authored-by: Andrés Miguel Rubio <[email protected]> * fix: [ANDROAPP-5930] remove old unnecessary header and modify edit en… (#3538) * fix: [ANDROAPP-5930] remove old unnecessary header and modify edit enrollment corners and header * fix: [ANDROAPP-5930] wait for idle in test * fix: [ANDROAPP-5930] refactor methods * [ANDROAPP-5952] input age prompt stays at beginning (#3543) * refactor custom icons Signed-off-by: Pablo <[email protected]> * fix: [ANDROAPP-5930] update design system and adapt input for textfieldValue * fix: [ANDROAPP-5930] add null checks for value format * fix: [ANDROAPP-5952] correct test * fix: [ANDROAPP-5952] amend rebase conflic resolution update design system --------- Signed-off-by: Pablo <[email protected]> Co-authored-by: Pablo <[email protected]> * [ANDROAPP-5805] Move details information to Event Data entry (#3528) * [ANDROAPP-5805] Simplify if else on EventDate * [ANDROAPP-5805] Remove MviIntent interface * [ANDROAPP-5805] Remove nullable parameters forced by using search * [ANDROAPP-5805] Add Event details section with report date * [ANDROAPP-5805] Add Event Org unit in details * [ANDROAPP-5805] Add Event Coordinates in details * [ANDROAPP-5805] Add Event Category Combo in details * [ANDROAPP-5805] Create Eventwithout registration and navigate to Dataentry * [ANDROAPP-5805] Add CreateEventUseCase * [ANDROAPP-5805] update saving attribute option combo * [ANDROAPP-5805] move PeriodUtils to common * [ANDROAPP-5805] Implement period selector for events * [ANDROAPP-5805] Set EventMode and allow org unit edition on creation * [ANDROAPP-5805] Add eventCatCombo parameter to equals method in FieldUiModelImpl * [ANDROAPP-5805] Remove Event Detail section * [ANDROAPP-5805] Remove date on CreateEventUseCase * [ANDROAPP-5805] load selected category option combo * [ANDROAPP-5805] fix test dependencies * [ANDROAPP-5805] fix ProgramEventTest * [ANDROAPP-5805] fix EventTest * [ANDROAPP-5805] ktlintFormat after rebasing custom icons * [ANDROAPP-5805] Add editable reason to EventCaptureForm * [ANDROAPP-5931] Collapse event details and cat combo sections if completed (#3530) Signed-off-by: Pablo <[email protected]> * [ANDROAPP-5805] fix collapsible when no coordinates * [ANDROAPP-5805] Fix ProgramEventTest * [ANDROAPP-5805] Fix FormTest * [ANDROAPP-5805] Fix EventTest * [ANDROAPP-5805] Fix ProgramEventTest * [ANDROAPP-5805] Add idlingResource to EventCaptureFormPresenter * [ANDROAPP-5805] Handle remove org unit when creating event * [ANDROAPP-5805] Handle adding cat combo * [ANDROAPP-5805] Handle adding cat combo * [ANDROAPP-5805] fix code smells * [ANDROAPP-5805] fix code smells --------- Signed-off-by: Pablo <[email protected]> Co-authored-by: Pablo <[email protected]> * Change start padding of event item when grouped (#3546) * Update android sdk 1.10.0 snapshot 36 (#3547) * fix: [ANDROAPP-5923] All enrollment screen crash (#3534) * prevents crash on All enrollments screen * removes deleted view tags from test * removes useless non-null access * Add idilingResource to event tests (#3550) * Update release start job (#3549) * release_start workflow * Update release-start.yml --------- Co-authored-by: manu <[email protected]> * Update version to 2.10 * fix: [ANDROAPP-6003] multiselection checked values (#3545) * fix: [ANDROAPP-5981] the app crashes randomly when scheduling new events in tracker program (#3521) * fix: [ANDROAPP-5981] filter by distinct events when updating to avoid duplicate calls to same event * fix: [ANDROAPP-5981] remove unnecessary subscription to observer, remove NonNullAsserted !! assertions for option codes and org unit codes * fix: [ANDROAPP-5981] code smells and small refactor * fix: [ANDROAPP-5981] update with requested changes * fix: [ANDROAPP-5981] ignore flaky test * [ANDROAPP-6010] defect event details catcombo scope fails when modifying org unit (#3555) * [ANDROAPP-6010] Adapt Event toolbar to new design * [ANDROAPP-6010] Set ProgramCaptureScope to event orgunit * [ANDROAPP-6010] check category combos for mandatory fields * fix: [ANDROAPP-6006] update changes on dashboard (#3554) * Add IdlingResource when completing an event (#3556) * Update android sdk 1.10.0 snapshot 37 (#3560) Co-authored-by: Andrés Miguel Rubio <[email protected]> * fix icon size and alignment of program stage item (#3552) Co-authored-by: Siddharth Agarwal <[email protected]> * fi: [ANDROAPP-6004] All {TE Type} search now show too many result. (#3553) * Update android sdk 1.10.0 snapshot 38 (#3562) * Update android sdk 1.10.0 snapshot 38 * Adapt unit tests * fix: [ANDROAPP-6017] only searched fields on searched bar (#3559) * update desyng system (#3544) Signed-off-by: Pablo <[email protected]> * add anr reports in sentry (#3532) Signed-off-by: Pablo <[email protected]> * [ANDROAPP-6007] Use default color in metadata icons (#3557) * use default color Signed-off-by: Pablo <[email protected]> * fix unit tests Signed-off-by: Pablo <[email protected]> * remove unused Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * fix: [ANDROAPP-6024] table resize dimensions (#3566) * [ANDROAPP-6023] Scheduled event missbehavior (#3565) * [ANDROAPP-6023] Remove Event initial step when scheduling and event * [ANDROAPP-6023] add event form aesthetics rounded corners * [ANDROAPP-6023] set entollment from schedule and by generation after create an enrollment as new events. * [ANDROAPP-6023] Set EventMode Schedule when entering data scheduling an event * [ANDROAPP-6023] Remove unused EventCaptureInitial package * [ANDROAPP-6023] Change Enter/Cancel button text by Enter/Skip * [ANDROAPP-6023] Set rounded corners on EventCaptureActivity sections * fix: [ANDROAPP-6008] user-friendly name on search parameters (#3563) * updates Dashboard only when new tei dashboard card is shown (#3567) * fix: [ANDROAPP-6013] don't save events without date or catCombo (#3569) * fix: [ANDROAPP-6040] Remove scroll to first empty item functionality (#3571) * fix: [ANDROAPP-6040] Remove scroll to first empty item functionality * fix: [ANDROAPP-6040] adapt test now that automatic scroll does not occur * [Androapp-5763] cropped number when data element name wraps into second line (#3570) * feat: [ANDROAPP-5763] implement Indicator Input throughout app * [ANDROAPP-5763] Use biggerOrEquals for filtering legends Signed-off-by: andresmr <[email protected]> * [ANDROAPP-5763] Set SurfaceColor.Container as default color Signed-off-by: andresmr <[email protected]> * [ANDROAPP-5763] Remove xml from IndicatorViewHolder Signed-off-by: andresmr <[email protected]> * [ANDROAPP-5763] Replace test robots Signed-off-by: andresmr <[email protected]> * [ANDROAPP-5763] Remove uncommented test code Signed-off-by: andresmr <[email protected]> * [ANDROAPP-5763] Move spacing to vertical arrangement Signed-off-by: andresmr <[email protected]> --------- Signed-off-by: andresmr <[email protected]> Co-authored-by: Xavier Molloy <[email protected]> * fix: [ANDROAPP-6038] improved management for Cancel event in OU dialog (#3572) * fix: [ANDROAPP-6038] enable add new button when exiting canceling OU dialog * fix: [ANDROAPP-6038] small code refactor * Update design library to 0.2-20240405.110637-52 (#3575) Signed-off-by: andresmr <[email protected]> * [ANDROAPP-6086] set today es event date when creating new event (#3577) Signed-off-by: andresmr <[email protected]> * fix: [ANDROAPP-6033] modify padding between ListCard components, add superior padding if item is first one in order to improve superior border visibility (#3568) * fix: [ANDROAPP-6011] freeze getting dashboard events (#3574) * fix: [ANDROAPP-6011] freeze getting dashboard events * fix test * fix test * access localdatastore in background thread (#3580) Signed-off-by: Pablo <[email protected]> * Create build-release-candidate.yml (#3573) * Create build-release-candidate.yml * Update build-release-candidate.yml * buid release candidate signing config Signed-off-by: Pablo <[email protected]> * set keystore path Signed-off-by: Pablo <[email protected]> * set missing env variables Signed-off-by: Pablo <[email protected]> * ktlint Signed-off-by: Pablo <[email protected]> * ignore schedule event test --------- Signed-off-by: Pablo <[email protected]> Co-authored-by: manu <[email protected]> * [ANDROAPP-6015] update design system (#3585) Signed-off-by: andresmr <[email protected]> * fix: [ANDROAPP-6091] days to scheduled day (#3578) * update version name (#3584) * fix: [ANDROAPP-6053] ANR on dataset list (#3583) * [ANDROAPP-5712] Update sync dialog when reopened (#3564) * Update sync dialog when reopened Signed-off-by: Pablo <[email protected]> * wait for compose to idle Signed-off-by: Pablo <[email protected]> * use indeterminate progress in granular sync Signed-off-by: Pablo <[email protected]> * wait for the data to be loaded Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * Get period step on background (#3582) Signed-off-by: Pablo <[email protected]> * fix: [ANDROAPP-6110] crash in program default metadata icon (#3594) * fix: Improve performance in home and event program screen (analytics tab) (#3595) * Improve performance in home screen (analytics tab) * Improve performance in program event screen (analytics tab) * Refactor condition * Restore deleted code * fix: [ANDROAPP-6103] month value in scheduling dialog (#3590) * fix component focus requester (#3587) Co-authored-by: Siddharth Agarwal <[email protected]> * [ANDROAPP-6106] Replace enrollment label with custom one (#3592) * replace enrollment label with custom one Signed-off-by: Pablo <[email protected]> * replace enrollment label with custom one in complete dialog Signed-off-by: Pablo <[email protected]> * Restore enrollment list label Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * Fix IndexOutOfBounds exception in SyncStat (#3597) Signed-off-by: Pablo <[email protected]> * fix: [ANDROAPP-5992] check program stage filters in WorkingListScope (#3600) * fix: [ANDROAPP-5992] check program stage filters in WorkingListScope * fix: [ANDROAPP-5992] check program stage filters in WorkingListScope * [ANDROAPP-6012] Display validation errors (#3599) * [ANDROAPP-6012] Display validation errors Signed-off-by: Pablo <[email protected]> * apply validation only for date value dates Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * Skip OU selection for single option in event creation (#3588) * skip OU selection when count is 1 * fix lint error * Fix nullable programUid for OURepository * Fix TEIPresenter Test * Code refactored:move functions to repository class * Fix lint error --------- Co-authored-by: Siddharth Agarwal <[email protected]> * fix: [ANDROAPP-6081] set current date for new enrollment (#3603) * [ANDROAPP-5949] OpenID login button overlaps with "Manage accounts" (#3606) Signed-off-by: Pablo <[email protected]> * fix: [ANDROAPP-6119] verify array size before accessing index (#3602) Co-authored-by: Xavier Molloy <[email protected]> * [ANDROAPP-5787] Use search scope in a referral (#3608) * [ANDROAPP-5787] Use search scope in a referral Signed-off-by: Pablo <[email protected]> * [ANDROAPP-5787] add test Signed-off-by: Pablo <[email protected]> * search scope must return search and capture org units Signed-off-by: Pablo <[email protected]> * search scope must return search and capture org units Signed-off-by: Pablo <[email protected]> * fix test Signed-off-by: Pablo <[email protected]> --------- Signed-off-by: Pablo <[email protected]> * browserstack build tag (#3610) * fix: [ANDROAPP-6123] key text in list cards (#3614) Co-authored-by: DavidAparicioAlbaAsenjo <[email protected]> * [ANDROAPP-5869] Provide different keys for fixedStickyHeader (#3607) Signed-off-by: Pablo <[email protected]> * fix: [ANDROAPP-5883] periods when orgunit is closed (#3613) * [ANDROAPP-5757] Field with error can't be disabled (#3609) Signed-off-by: Pablo <[email protected]> * [ANDROAPP-6126] Date parse exception when searching by unfinished date string (#3604) Signed-off-by: Pablo <[email protected]> * fix: [ANDROAPP-6062] clear search fields when required attributes to search (#3581) * fix: [ANDROAPP-6062] clear search fields when required attributes to search * add clear test --------- Signed-off-by: Pablo <[email protected]> Signed-off-by: andresmr <[email protected]> Co-authored-by: Siddharth Agarwal <[email protected]> Co-authored-by: Siddharth Agarwal <[email protected]> Co-authored-by: Andrés Miguel Rubio <[email protected]> Co-authored-by: Xavier Molloy <[email protected]> Co-authored-by: Sasikanth Miriyampalli <[email protected]> Co-authored-by: Manu Muñoz <[email protected]> Co-authored-by: Xavier Molloy <[email protected]> Co-authored-by: FerdyRod <[email protected]> Co-authored-by: = <[email protected]> Co-authored-by: dhis2-bot <[email protected]> Co-authored-by: manu <[email protected]> Co-authored-by: FerdyRod <[email protected]> Co-authored-by: Víctor García <[email protected]> Co-authored-by: GitHub Actions Bot <[email protected]> Co-authored-by: DavidAparicioAlbaAsenjo <[email protected]> * fix landscape support Signed-off-by: andresmr <[email protected]> --------- Signed-off-by: andresmr <[email protected]> Signed-off-by: Pablo <[email protected]> Co-authored-by: Pablo <[email protected]> Co-authored-by: Siddharth Agarwal <[email protected]> Co-authored-by: Siddharth Agarwal <[email protected]> Co-authored-by: Xavier Molloy <[email protected]> Co-authored-by: Sasikanth Miriyampalli <[email protected]> Co-authored-by: Manu Muñoz <[email protected]> Co-authored-by: Xavier Molloy <[email protected]> Co-authored-by: FerdyRod <[email protected]> Co-authored-by: = <[email protected]> Co-authored-by: dhis2-bot <[email protected]> Co-authored-by: manu <[email protected]> Co-authored-by: FerdyRod <[email protected]> Co-authored-by: Víctor García <[email protected]> Co-authored-by: GitHub Actions Bot <[email protected]> Co-authored-by: DavidAparicioAlbaAsenjo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and include the related jira issue if it exists.
[ jira issue ](https://dhis2.atlassian.net/browse/ANDROAPP-
Solution description
If this PR is a fix include a brief description on how the issue is solved.
Covered unit test cases
Describe the tests that you ran to verify your changes.
Where did you test this issue?
Which Android versions did you test this issue?
Checklist