Made quick review of the code. Couple of as I would describe it "code smells", could you please respond to my concerns? #32
Labels
Comments
dhindrik
added a commit
that referenced
this issue
Oct 1, 2024
|
Thank you for the feedback. I have now changed to FlushAsync and I dive deeper into how to change the Flush strategy, |
|
I am evaluating TinyInsights as an AppCenter replacement for Diagnostics and Analytics and noticed that the app is significantly slower when TinyInsights is being used. Could maybe have something to do with the flushing strategy since this app is reporting a lot of custom events. |
|
I have open a PR regarding Flush, what do you think about it, #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since there is no Discussions enabled for the project let me ask couple of questions in form of an issue:
Client.Flush()is used for Info messages and page count metric from what I can see in your code. It could be Ok for handling exceptions, but I doubt it's a good idea for all Info events and page counts. It's not configurable either. AFAIK Ms recommendation is to let automatic flush work for most of the cases, that flushes collected telemetry data to remote server like once every 30 sec:https://devblogs.microsoft.com/premier-developer/application-insights-use-case-for-telemetryclient-flush-calls/
Could you explain why and if you have any plans to change the behavior.
sync Client.Flush();inside itslef, while Client.FlushAsync() is available. Any comment on that?Thank you!
The text was updated successfully, but these errors were encountered: