Cheaper and safe caching for py_capsule! and py_capsule_fn! #268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
py_capsule!
andpy_capsule_fn!
macros generateretrieve
functions that cache their results for subsequent calls.Prior to this commit, caching is done with a generated unsafe
static mut
item whose access is made thread-safe by astd::sync::Once
on the side. However this synchronization is unnecessary sinceretreive
takes aPython<'_>
parameter that indicates that the GIL is held.This changes the cache to use safe
static
item instead, withGILProtected
for synchronization-free thread-safety andOnceCell
for interior mutability. As a bonus, this removes the need for cache-relatedunsafe
code in generatedretrieve
functions.This adds a dependency to the
once_cell
crate, which can be removed whenOnceCell
becomes stable in the standard library: rust-lang/rust#74465Alternatively
OnceCell
could be replaced withUnsafeCell
plus someunsafe
code, effectively inlining the core of the logic ofOnceCell
.Fixes #263