-
Notifications
You must be signed in to change notification settings - Fork 161
Custom unsupported page for users trying to sign in from within X. #3520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR creates a custom unsupported browser page specifically for users accessing the application from within X (Twitter's in-app browser), while maintaining the generic unsupported page for other in-app browsers.
Key Changes:
- Refactored the main unsupported page to detect X's browser via user agent and conditionally render appropriate views
- Created X-specific instructions with visual toolbar mockups to guide users on opening links in their system browser
- Extracted the original generic unsupported page content into a reusable component
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
+page.svelte |
Implements user agent detection to route between X-specific and generic unsupported views |
components/views/Generic.svelte |
Moved original unsupported page content with generic instructions for all in-app browsers |
components/views/X.svelte |
New X/Twitter-specific view with step-by-step visual guidance using toolbar mockups |
components/ui/Toolbar.svelte |
Visual toolbar container component for illustrative browser UI elements |
components/ui/ToolbarButton.svelte |
Styled button component mimicking browser toolbar buttons |
components/ui/ToolbarHighlight.svelte |
Highlight wrapper component with animated concentric border rings for emphasis |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Custom unsupported page for users trying to sign in from within X.
Changes
components/views/Generic.svelte.components/views/X.sveltefor X specific instructions.Toolbar*components for illustrative guidance in above instructions.