Skip to content

Conversation

@sea-snake
Copy link
Contributor

@sea-snake sea-snake commented Nov 27, 2025

Custom unsupported page for users trying to sign in from within X.

Changes

  • Move generic unsupported page as is into components/views/Generic.svelte.
  • Create components/views/X.svelte for X specific instructions.
  • Create Toolbar* components for illustrative guidance in above instructions.
image

@sea-snake sea-snake requested a review from aterga November 27, 2025 16:53
@aterga aterga requested a review from Copilot November 28, 2025 13:03
Copilot finished reviewing on behalf of aterga November 28, 2025 13:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR creates a custom unsupported browser page specifically for users accessing the application from within X (Twitter's in-app browser), while maintaining the generic unsupported page for other in-app browsers.

Key Changes:

  • Refactored the main unsupported page to detect X's browser via user agent and conditionally render appropriate views
  • Created X-specific instructions with visual toolbar mockups to guide users on opening links in their system browser
  • Extracted the original generic unsupported page content into a reusable component

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
+page.svelte Implements user agent detection to route between X-specific and generic unsupported views
components/views/Generic.svelte Moved original unsupported page content with generic instructions for all in-app browsers
components/views/X.svelte New X/Twitter-specific view with step-by-step visual guidance using toolbar mockups
components/ui/Toolbar.svelte Visual toolbar container component for illustrative browser UI elements
components/ui/ToolbarButton.svelte Styled button component mimicking browser toolbar buttons
components/ui/ToolbarHighlight.svelte Highlight wrapper component with animated concentric border rings for emphasis

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aterga aterga added this pull request to the merge queue Nov 28, 2025
Merged via the queue into main with commit 3611a9e Nov 28, 2025
75 checks passed
@aterga aterga deleted the sea-snake/unsupported-x branch November 28, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants