Adding Tip Page #78
Comments
Alexintosh
added
help wanted
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 10.0 DAI (10.0 USD @ $1.0/DAI) attached to it as part of the dexlab-io fund.
|
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Workers have applied to start work. These users each claimed they can complete the work by 2 months, 4 weeks from now. 1) aesthytik has applied to start work (Funders only: approve worker | reject worker). I will make a nice tip page showing list of tippings with animation on receiving the tip Learn more on the Gitcoin Issue Details page. |
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Workers have applied to start work. These users each claimed they can complete the work by 2 months, 4 weeks from now. 1) e18r has applied to start work (Funders only: approve worker | reject worker). I'd love to develop this feature, not so much for the 10 DAI, but mostly out of the desire to be a part of this beautifully crafted dapp. The Tip page will be a new component which will live in a homonomous folder under src/pages and whose route will be added to App.js. I will use the Payment component as a reference, and I will try to match the clean and minimalistic design of the other components. Learn more on the Gitcoin Issue Details page. |
|
Awesome. Props on moving this idea forward @Alexintosh & @perminder-klair 🙏 |
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 1 month, 4 weeks from now. 1) e18r has been approved to start work. I'd love to develop this feature, not so much for the 10 DAI, but mostly out of the desire to be a part of this beautifully crafted dapp. The Tip page will be a new component which will live in a homonomous folder under src/pages and whose route will be added to App.js. I will use the Payment component as a reference, and I will try to match the clean and minimalistic design of the other components. Learn more on the Gitcoin Issue Details page. 2) abhinandansharma has applied to start work (Funders only: approve worker | reject worker). Knows a bit of Computer Science. I may help with your work. Learn more on the Gitcoin Issue Details page. |
Created a new tab in desktop mode called "Tip", where the Tip component will be displayed in a modal, just like the Payment modal. Also, created routing so that it is possible to navigate to /address/:id/tip and make this modal open, both from desktop and from mobile. Finally, added a "lastTab" state entry so the dapp knows which tab to open once it is closed by a user. Created a dummy QR code inside the Tip modal.
|
@e18r Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
|
I will work on this on Wednesday, no need to worry! |
The tip page has a new layout. On the right side, it watches for any incoming payments and registers them on the left side, which uses the component RecentPayments, with a few modifications.
|
@e18r Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
|
I'll be working on it today. No worries. |
The recent payments component was updated to handle new tips by filtering out transactions that didn't happen in the current session, and also by updating itself on the go on each tip received.
A confetti animation shows whenever a tip is received.
* The Tip component is called with the appropiate parameters from inside the mobile view, so that it renders correctly. * The Watcher object is initiated as soon as the Tip component is loaded in case it has the active tab. This didn't happen before as the tab navigation allowed it to start after the component was loaded.
* Stores the confetti's z-index value on the component's state * Dynamically changes this value when the animation starts and stops
* Created a new method of the Dashboard component, which changes the URL of the current page according to the active tab * Called the new method from the tab change handlers for desktop and mobile
* Changed the padding of the status container so that the status text can be displayed in one line on desktop * Changed the padding of the payment info container so that the receiving address container has more space * Changed the crypto token info so that it contains a dropdown menu
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 10.0 DAI (10.0 USD @ $1.0/DAI) has been submitted by: @Alexintosh please take a look at the submitted work:
|
|
I'll paste my feedback here as well
Visual ref |
|
I would make the following small style changes on the confetti:
Colors: |
The payment status section of the tip payment watcher was removed.
…o#78) The CryptoAmount component was updated to have a smaller padding, so that the dropdown list button didn't overlap the selection name.
|
Hi @dimarconicola @Alexintosh is there anything else you'd like me to change or improve? |
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 10.0 DAI (10.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @e18r.
|
Dexpay is a modularized and extensible point of sale which enables Merchants to accept payments in cryptocurrencies without being exposed to volatility.
As an early user, I want to have a tipping page to use for instance in live streaming.
This could live in a url like
/address/:address/tip, the way is supposed to work is the following:You can discuss the development with me and @perminder-klair in our Discord Channel
The text was updated successfully, but these errors were encountered: