Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PWA. #37

Open
3 tasks done
Alexintosh opened this issue Feb 1, 2019 · 4 comments
Open
3 tasks done

Add support for PWA. #37

Alexintosh opened this issue Feb 1, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Alexintosh
Copy link
Member

Alexintosh commented Feb 1, 2019

  • Icon not working

  • Add splash screen

  • Clear PWA cache on app version change

@perminder-klair
Copy link
Collaborator

@Alexintosh we have issue with PWA service worker.
It updated cache whenever new code is pushed. But client/user can only use new code when closing and opening tab.
It does not works with refresh or hard refresh such as window.location.reload(true);

Solution, can be letting User know some kind of message like: "New update is available, please close this tab and open new one again."

Any suggestions?

@perminder-klair
Copy link
Collaborator

Or there is way by ejecting from CRA as discussed here: facebook/create-react-app#5316 (comment)

@perminder-klair
Copy link
Collaborator

opening again, as its not updating client production app after update.

@perminder-klair
Copy link
Collaborator

disabled PWA for now.

@Alexintosh Alexintosh added enhancement New feature or request and removed sprint-2 labels Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants