update request handlers to return list objects for list requests

Author: EddM

lib/stripe_mock.rb

@@ -5,11 +5,12 @@
 require 'stripe'
 
 require 'stripe_mock/version'
-require 'stripe_mock/data'
-require 'stripe_mock/list'
 require 'stripe_mock/util'
 require 'stripe_mock/error_queue'
 
+require 'stripe_mock/data'
+require 'stripe_mock/data/list'
+
 require 'stripe_mock/errors/stripe_mock_error'
 require 'stripe_mock/errors/unsupported_request_error'
 require 'stripe_mock/errors/uninitialized_instance_error'

lib/stripe_mock/data.rb

@@ -440,5 +440,10 @@ def self.mock_delete_discount_response
         :id => "di_test_coupon"
       }
     end
+
+    def self.mock_list_object(data, params = {})
+      list = StripeMock::Data::List.new(data, params)
+      list.to_h
+    end
   end
 end

lib/stripe_mock/list.rb renamed to lib/stripe_mock/data/list.rb

@@ -22,6 +22,20 @@ def has_more?
         (offset + limit) < data.size
       end
 
+      def method_missing(method_name, *args, &block)
+        hash = to_hash
+
+        if hash.keys.include?(method_name)
+          hash[method_name]
+        else
+          super
+        end
+      end
+
+      def respond_to?(method_name, priv = false)
+        to_hash.keys.include?(method_name) || super
+      end
+
       private
 
       # TODO: REFACTOR

lib/stripe_mock/request_handlers/cards.rb

@@ -22,10 +22,9 @@ def create_card(route, method_url, params, headers)
       def retrieve_cards(route, method_url, params, headers)
         route =~ method_url
         customer = assert_existence :customer, $1, customers[$1]
-
         cards = customer[:cards]
-        cards[:count] = cards[:data].length
-        cards
+
+        Data.mock_list_object(cards[:data])
       end
 
       def retrieve_card(route, method_url, params, headers)

lib/stripe_mock/request_handlers/charges.rb

@@ -32,15 +32,15 @@ def new_charge(route, method_url, params, headers)
 
       def get_charges(route, method_url, params, headers)
         params[:offset] ||= 0
-        params[:count] ||= 10
+        params[:limit] ||= 10
 
         clone = charges.clone
 
         if params[:customer]
           clone.delete_if { |k,v| v[:customer] != params[:customer] }
         end
 
-        clone.values[params[:offset], params[:count]]
+        Data.mock_list_object(clone.values, params)
       end
 
       def get_charge(route, method_url, params, headers)

lib/stripe_mock/request_handlers/coupons.rb

@@ -25,7 +25,7 @@ def delete_coupon(route, method_url, params, headers)
       end
 
       def list_coupons(route, method_url, params, headers)
-        coupons.values
+        Data.mock_list_object(coupons.values, params)
       end
 
     end

lib/stripe_mock/request_handlers/customers.rb

@@ -69,7 +69,7 @@ def get_customer(route, method_url, params, headers)
       end
 
       def list_customers(route, method_url, params, headers)
-        customers.values
+        Data.mock_list_object(customers.values, params)
       end
 
     end

lib/stripe_mock/request_handlers/invoice_items.rb

@@ -32,7 +32,7 @@ def delete_invoice_item(route, method_url, params, headers)
       end
 
       def list_invoice_items(route, method_url, params, headers)
-        invoice_items.values
+        Data.mock_list_object(invoice_items.values, params)
       end
 
       def get_invoice_item(route, method_url, params, headers)

lib/stripe_mock/request_handlers/invoices.rb

@@ -26,15 +26,15 @@ def update_invoice(route, method_url, params, headers)
 
       def list_invoices(route, method_url, params, headers)
         params[:offset] ||= 0
-        params[:count] ||= 10
+        params[:limit] ||= 10
 
         result = invoices.clone
 
         if params[:customer]
           result.delete_if { |k,v| v[:customer] != params[:customer] }
         end
 
-        result.values[params[:offset], params[:count]]
+        Data.mock_list_object(result.values, params)
       end
 
       def get_invoice(route, method_url, params, headers)

lib/stripe_mock/request_handlers/plans.rb

@@ -32,7 +32,7 @@ def delete_plan(route, method_url, params, headers)
       end
 
       def list_plans(route, method_url, params, headers)
-        plans.values
+        Data.mock_list_object(plans.values)
       end
 
     end

spec/list_spec.rb

@@ -47,6 +47,17 @@
     )
   end
 
+  it "delegates other methods to hash keys" do
+    list = StripeMock::Data::List.new([double, double, double])
+
+    expect(list).to respond_to(:data)
+    expect(list.data).to be_kind_of(Array)
+    expect(list.object).to eq("list")
+    expect(list.has_more).to eq(false)
+    expect(list.url).to eq("/v1/doubles")
+    expect { list.foobar }.to raise_error(NoMethodError)
+  end
+
   context "with a limit" do
     it "accepts a limit which is reflected in the data returned" do
       list = StripeMock::Data::List.new([double] * 25)

spec/shared_stripe_examples/charge_examples.rb

@@ -120,21 +120,21 @@
     end
 
     it "stores charges for a customer in memory" do
-      expect(@customer.charges.map(&:id)).to eq([@charge.id])
+      expect(@customer.charges.data.map(&:id)).to eq([@charge.id])
     end
 
     it "stores all charges in memory" do
-      expect(Stripe::Charge.all.map(&:id)).to eq([@charge.id, @charge2.id])
+      expect(Stripe::Charge.all.data.map(&:id)).to eq([@charge.id, @charge2.id])
     end
 
     it "defaults count to 10 charges" do
       11.times { Stripe::Charge.create }
-      expect(Stripe::Charge.all.count).to eq(10)
+      expect(Stripe::Charge.all.data.count).to eq(10)
     end
 
-    context "when passing count" do
+    context "when passing limit" do
       it "gets that many charges" do
-        expect(Stripe::Charge.all(count: 1).count).to eq(1)
+        expect(Stripe::Charge.all(limit: 1).count).to eq(1)
       end
     end
   end

spec/shared_stripe_examples/coupon_examples.rb

@@ -88,7 +88,7 @@
     Stripe::Coupon.create({ id: 'Coupon Two', amount_off: 3000 })
 
     all = Stripe::Coupon.all
-    expect(all.length).to eq(2)
+    expect(all.count).to eq(2)
     expect(all.map &:id).to include('Coupon One', 'Coupon Two')
     expect(all.map &:amount_off).to include(1500, 3000)
   end

spec/shared_stripe_examples/customer_examples.rb

@@ -197,7 +197,7 @@ def gen_card_tk
     Stripe::Customer.create({ email: '[email protected]' })
 
     all = Stripe::Customer.all
-    expect(all.length).to eq(2)
+    expect(all.count).to eq(2)
     expect(all.map &:email).to include('[email protected]', '[email protected]')
   end
 

spec/shared_stripe_examples/invoice_examples.rb

@@ -62,7 +62,7 @@
 
     context "when passing count" do
       it "gets that many invoices" do
-        expect(Stripe::Invoice.all(count: 1).count).to eq(1)
+        expect(Stripe::Invoice.all(limit: 1).count).to eq(1)
       end
     end
   end

spec/shared_stripe_examples/invoice_item_examples.rb

@@ -40,7 +40,7 @@
 
     it "retrieves all invoice items" do
       all = Stripe::InvoiceItem.all
-      expect(all.length).to eq(2)
+      expect(all.count).to eq(2)
       expect(all.map &:amount).to include(1075, 1540)
     end
   end

spec/shared_stripe_examples/plan_examples.rb

@@ -96,7 +96,7 @@
     stripe_helper.create_plan(id: 'Plan Two', amount: 98765)
 
     all = Stripe::Plan.all
-    expect(all.length).to eq(2)
+    expect(all.count).to eq(2)
     expect(all.map &:id).to include('Plan One', 'Plan Two')
     expect(all.map &:amount).to include(54321, 98765)
   end