-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circular heatmap is not responsive #347
Comments
Hi @vbakke, thank you for your effort.
It depends how DSOMM is used. I think more often the table is used. Unfortunately, I am currently not having statistics about usage to proof which page is used more often.
I did some tests in the browser with different simulate phones, much better than beforehand! Thank you! Looking forward to your PR.
Looks good, happy to get a PR.
Looks good, happy to get a PR.
Looks good, happy to get a PR.
Looks good, happy to get a PR.
Looks good, happy to get a PR. Kind regards |
If you use DSOMM mainly to show progress of your maturity over different teams, it would be good. I think a feature toggle to configure the main page would work here. |
Sure. We have I don't disagree that the matrix is the page that many people use the most. But I'd like to consider both experienced users, and the ones that are testing out if DSOMM is something for their organization. In a business intelligence approach (BI world), it is recommended to start with the top view, before drilling down into the details. The page with circular sectors is much more "brandable" (if that is a word), than the matrix. I think the sectors will stick to people's minds more. It will not be hard for the experienced users to bookmark the Matrix, rather than the homepage. Or just type a little extra in the address bar to jump straight to the matrix. Another approach Though, this might be a bit overkill, for something like this. |
This issue has been automatically marked as |
hey, git bot, calm down. didn't you see that a PR was posted just a couple of days a ago...? |
comment to keep the stale-bot happy |
Try opening https://dsomm.owasp.org/circular-heatmap on a mobile, or a smaller sized browser. It becomes very hard to use.
I have created an experimental branch on https://dsomm.pages.dev/ with a couple of suggestions:
meta.yaml
, notgenerated.yaml
.meta.yaml
takes precedence over the teams in localstorage, and generated.yaml.(Ignore the yellow background. it is to that I don't fix them that easily.)
I have more suggestions for improvements, but have not implemented them anywhere yet.
@wurstbrot, please comment on whether you like some of the suggestions. And I can port them to new pull requests, or alter them if I miss something important.
The text was updated successfully, but these errors were encountered: