Skip to content

Commit fcdd43e

Browse files
authored
php 8.4 support (#13)
1 parent 9d0bf47 commit fcdd43e

File tree

6 files changed

+4
-52
lines changed

6 files changed

+4
-52
lines changed

.github/workflows/formats.yml

-3
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,5 @@ jobs:
3030
- name: Coding Style Checks
3131
run: composer test:lint
3232

33-
- name: Refactor Checks
34-
run: composer test:refactor
35-
3633
- name: Type Checks
3734
run: composer test:types

.github/workflows/tests.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
fail-fast: true
1010
matrix:
1111
os: [ubuntu-latest]
12-
php: [8.1, 8.2]
12+
php: [8.1, 8.2, 8.3, 8.4]
1313
stability: [prefer-lowest, prefer-stable]
1414

1515
name: Tests php@${{ matrix.php }} - ${{ matrix.os }} - ${{ matrix.stability }}

CONTRIBUTING.md

+1-7
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,6 @@ Run all tests:
4949
composer test
5050
```
5151

52-
Check code quality:
53-
54-
```bash
55-
composer test:refactor
56-
```
57-
5852
Check types:
5953

6054
```bash
@@ -82,4 +76,4 @@ If you want to check things work against a specific version of PHP, you may incl
8276
docker compose build --build-arg PHP=8.2
8377
```
8478

85-
The default PHP version will always be the lowest version of PHP supported by jira-php.
79+
The default PHP version will always be the lowest version of PHP supported by jira-php.

composer.json

+1-5
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,12 @@
2222
},
2323
"require-dev": {
2424
"laravel/pint": "^1.2.0",
25+
"mockery/mockery": "^1.6",
2526
"nunomaduro/collision": "^7.0.0",
2627
"pestphp/pest": "^2.0.0",
27-
"pestphp/pest-plugin-mock": "^2.0.0",
2828
"phpstan/extension-installer": "^1.2",
2929
"phpstan/phpstan": "^1.8.6",
3030
"phpstan/phpstan-strict-rules": "^1.4",
31-
"rector/rector": "^0.15",
3231
"symfony/var-dumper": "^6.2.0"
3332
},
3433
"autoload": {
@@ -56,14 +55,11 @@
5655
},
5756
"scripts": {
5857
"lint": "pint --preset laravel -v --ansi",
59-
"refactor": "rector --debug --ansi",
6058
"test:lint": "pint --preset laravel --test -v --ansi",
61-
"test:refactor": "rector --dry-run --ansi",
6259
"test:types": "phpstan analyse --ansi",
6360
"test:unit": "pest --colors=always --min=100 --order-by=random --coverage",
6461
"test": [
6562
"@test:lint",
66-
"@test:refactor",
6763
"@test:types",
6864
"@test:unit"
6965
]

rector.php

-35
This file was deleted.

src/Jira.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public static function client(string $username, string $password, string $host):
1919

2020
$headers = Headers::withAuthorization(basicAuthentication: $basicAuthentication);
2121

22-
$client = new GuzzleClient();
22+
$client = new GuzzleClient;
2323

2424
$httpTransporter = new HttpTransporter(client: $client, baseUri: $baseUri, headers: $headers);
2525

0 commit comments

Comments
 (0)