Skip to content

Commit d204db0

Browse files
committedJul 11, 2023
Updates dependencies (typescript-eslint) & lints
1 parent f90def9 commit d204db0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+227
-238
lines changed
 

‎.eslintrc.base.json

+11-18
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
},
55
"extends": [
66
"eslint:recommended",
7-
"plugin:@typescript-eslint/recommended",
8-
"plugin:@typescript-eslint/recommended-requiring-type-checking",
7+
"plugin:@typescript-eslint/strict-type-checked",
8+
"plugin:@typescript-eslint/stylistic-type-checked",
99
"plugin:import/recommended",
1010
"plugin:import/typescript",
1111
"prettier"
@@ -212,17 +212,17 @@
212212
}
213213
}
214214
],
215+
"@typescript-eslint/class-literal-property-style": "off",
215216
"@typescript-eslint/consistent-type-assertions": [
216217
"error",
217218
{
218219
"assertionStyle": "as",
219220
"objectLiteralTypeAssertions": "allow-as-parameter"
220221
}
221222
],
223+
"@typescript-eslint/consistent-type-definitions": "off",
222224
"@typescript-eslint/consistent-type-imports": ["error", { "disallowTypeAnnotations": false }],
223-
"@typescript-eslint/explicit-function-return-type": "off",
224-
"@typescript-eslint/explicit-member-accessibility": "off",
225-
"@typescript-eslint/explicit-module-boundary-types": "off", // TODO@eamodio revisit
225+
"@typescript-eslint/dot-notation": "off",
226226
"@typescript-eslint/naming-convention": [
227227
"error",
228228
{
@@ -269,29 +269,23 @@
269269
}
270270
}
271271
],
272-
"@typescript-eslint/no-dynamic-delete": "error",
272+
"@typescript-eslint/no-confusing-void-expression": [
273+
"error",
274+
{ "ignoreArrowShorthand": true, "ignoreVoidOperator": true }
275+
],
273276
"@typescript-eslint/no-empty-function": "off",
274-
"@typescript-eslint/no-empty-interface": "error",
275277
"@typescript-eslint/no-explicit-any": "off",
276-
"@typescript-eslint/no-extraneous-class": "error",
277-
"@typescript-eslint/no-floating-promises": "error",
278278
"@typescript-eslint/no-inferrable-types": ["warn", { "ignoreParameters": true, "ignoreProperties": true }],
279279
"@typescript-eslint/no-invalid-void-type": "off", // Seems to error on `void` return types
280-
"@typescript-eslint/no-meaningless-void-operator": "error",
281280
"@typescript-eslint/no-misused-promises": ["error", { "checksVoidReturn": false }],
282-
"@typescript-eslint/no-namespace": "error",
283281
"@typescript-eslint/no-non-null-assertion": "off",
284-
"@typescript-eslint/no-non-null-asserted-nullish-coalescing": "error",
285-
"@typescript-eslint/no-throw-literal": "error",
286-
// "@typescript-eslint/no-unnecessary-condition": ["error", { "allowConstantLoopConditions": true }],
282+
"@typescript-eslint/no-redundant-type-constituents": "off",
287283
"@typescript-eslint/no-unnecessary-condition": "off",
288284
"@typescript-eslint/no-unnecessary-boolean-literal-compare": "off",
289-
"@typescript-eslint/no-unnecessary-type-arguments": "error",
290285
"@typescript-eslint/no-unsafe-argument": "off",
291286
"@typescript-eslint/no-unsafe-assignment": "off",
292287
"@typescript-eslint/no-unsafe-call": "off",
293288
"@typescript-eslint/no-unsafe-member-access": "off",
294-
"@typescript-eslint/no-unsafe-return": "error",
295289
"@typescript-eslint/no-unused-expressions": ["warn", { "allowShortCircuit": true }],
296290
"@typescript-eslint/no-unused-vars": [
297291
"warn",
@@ -302,9 +296,8 @@
302296
"varsIgnorePattern": "^_$"
303297
}
304298
],
299+
"@typescript-eslint/no-unsafe-enum-comparison": "off",
305300
"@typescript-eslint/no-use-before-define": ["error", { "functions": false, "classes": false }],
306-
"@typescript-eslint/no-useless-constructor": "error",
307-
"@typescript-eslint/non-nullable-type-assertion-style": "error",
308301
"@typescript-eslint/prefer-for-of": "warn",
309302
"@typescript-eslint/prefer-includes": "warn",
310303
"@typescript-eslint/prefer-literal-enum-member": ["warn", { "allowBitwiseExpressions": true }],

‎package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -14561,7 +14561,7 @@
1456114561
"graph:unlink": "yarn unlink @gitkraken/gitkraken-components && yarn install --force",
1456214562
"icons:apply": "node ./scripts/applyIconsContribution.js",
1456314563
"icons:svgo": "svgo -q -f ./images/icons/ --config svgo.config.js",
14564-
"lint": "eslint \"src/**/*.ts?(x)\" --fix",
14564+
"lint": "eslint \"src/**/*.ts?(x)\"",
1456514565
"lint:webviews": "eslint \"src/webviews/apps/**/*.ts?(x)\" --fix",
1456614566
"package": "vsce package --yarn",
1456714567
"package-pre": "yarn run patch-pre && yarn run package --pre-release",
@@ -14605,7 +14605,7 @@
1460514605
"node-fetch": "2.6.9",
1460614606
"os-browserify": "0.3.0",
1460714607
"path-browserify": "1.0.1",
14608-
"react": "16.8.4",
14608+
"react": "18.3.0-canary-7ac5e9a60-20230508",
1460914609
"react-dom": "16.8.4",
1461014610
"sortablejs": "1.15.0"
1461114611
},
@@ -14616,8 +14616,8 @@
1461614616
"@types/react-dom": "17.0.17",
1461714617
"@types/sortablejs": "1.15.1",
1461814618
"@types/vscode": "1.78.1",
14619-
"@typescript-eslint/eslint-plugin": "5.61.0",
14620-
"@typescript-eslint/parser": "5.61.0",
14619+
"@typescript-eslint/eslint-plugin": "6.0.0",
14620+
"@typescript-eslint/parser": "6.0.0",
1462114621
"@vscode/test-electron": "2.3.3",
1462214622
"@vscode/test-web": "0.0.44",
1462314623
"@vscode/vsce": "2.19.0",

0 commit comments

Comments
 (0)
Please sign in to comment.