Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contact form added #37

Open
wants to merge 10 commits into
base: vue
Choose a base branch
from
Open

contact form added #37

wants to merge 10 commits into from

Conversation

samarth-1729
Copy link

The contact form has been added in the about us page

@killbotXD
Copy link
Contributor

@samarth-1729 Always add screenshots in the description when you add/improve UI

@samarth-1729
Copy link
Author

Screenshot (26)
Screenshot (27)
ScreenShots added

src/router/index.js Outdated Show resolved Hide resolved
src/views/AboutUs.vue Outdated Show resolved Hide resolved
src/views/AboutUs.vue Outdated Show resolved Hide resolved
@Sandesh1013 Sandesh1013 linked an issue Sep 5, 2020 that may be closed by this pull request
@samarth-1729
Copy link
Author

URL is modified

package.json Outdated Show resolved Hide resolved
src/views/AboutUs.vue Outdated Show resolved Hide resolved
src/views/AboutUs.vue Outdated Show resolved Hide resolved
@samarth-1729
Copy link
Author

contact button added in footer

@samarth-1729
Copy link
Author

Screenshot (35)

footer size corrected

src/views/AboutUs.vue Outdated Show resolved Hide resolved
src/views/AboutUs.vue Outdated Show resolved Hide resolved
src/views/AboutUs.vue Outdated Show resolved Hide resolved
counter=true
v-model="mobileNo"
:rules="numberRules")
div.form-row(name="inputSuggestion")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

src/views/AboutUs.vue Outdated Show resolved Hide resolved
max-height: 300px;
max-width: 400px;
margin-top: 40px;
border-radius: 20px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant style

src/views/AboutUs.vue Outdated Show resolved Hide resolved
src/views/AboutUs.vue Outdated Show resolved Hide resolved
v-col.py-4.text-center.white--text.font-weight-bold(color="secondary" cols="12") {{ new Date().getFullYear() }} — Devlup Labs
v-col.my-n5.text-center.font-weight-bold(color="secondary" cols="12")
v-btn.text-center.white--text.font-weight-bold(text='Primary',
to='./about', color='white' large
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use relative links

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually dont use the button it stays active when on the about us page, use plain text as the link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. no need to add commas

v-icon {{link.icon}}
v-col.py-4.text-center.white--text.font-weight-bold(color="secondary" cols="12") {{ new Date().getFullYear() }} — Devlup Labs
v-col.my-n5.text-center.font-weight-bold(color="secondary" cols="12")
v-btn.text-center.white--text.font-weight-bold(text='Primary',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does text=Primary do?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without it button is looking completly while

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

white?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samarth-1729 you mean the text prop adds color to the button?

@killbotXD
Copy link
Contributor

@Sandesh1013 I have noticed a few of console errors please

  • resolve console errors
  • remove the button from the footer and add plain old text as the button stays active when on the about us page

v-icon {{link.icon}}
v-col.py-4.text-center.white--text.font-weight-bold(color="secondary" cols="12") {{ new Date().getFullYear() }} — Devlup Labs
v-col.my-n5.text-center.font-weight-bold(color="secondary" cols="12")
v-btn.text-center.white--text.font-weight-bold(text='Primary'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is text='Primary' necessary? what does it do?

@@ -46,8 +46,8 @@ v-container(fluid='' style='margin: 0px; padding: 0px; width: 100%;')
div.container.col-sm-10(class="my-5" name="")
v-row(class="no-gutters pb-5" id="formRow")
div.col-md-5(class="pt-11 pl-7 pb-0" align="center" justify="center")
v-img.img-fluid.mt-10(src="../assets/contactUs.png"
max-height='300' max-width='400'
v-img.img-fluid.mt-40(src="../assets/contactUs.png"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

margin does not have sizes more than 16 in vuetify, why 40?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact Us tab
3 participants