You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In order to resolve #1023 we need to allow DevWorkspaceRouting objects to contain annotations which should be applied to the service created for a workspace.
Based on devfile/api#632 (comment), it seems like the service annotations from all of the devworkspace's container components should be aggregated and added as annotations to the workspace's service:
As discussed in today's call, we changed the proposal to have container level annotation defines deployment & service annotation, and move ingress/route annotation to endpoint level.
Since currently we have all containers defined within same pod share the same service. In the future, if we want to have multiple services for a same pod, we can add service annotation to endpoint level, which takes priority to container level service annotation and overwrites it when generating the service resource spec.
The text was updated successfully, but these errors were encountered:
Once this issue is resolved, a follow-up issue would be to support component.annotations.service from the devfile API. Another issue should be made for that topic.
In order to resolve #1023 we need to allow DevWorkspaceRouting objects to contain annotations which should be applied to the service created for a workspace.
Based on devfile/api#632 (comment), it seems like the service annotations from all of the devworkspace's container components should be aggregated and added as annotations to the workspace's service:
The text was updated successfully, but these errors were encountered: