Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service Annotations to the DevWorkspaceRouting CRD #1293

Open
AObuchow opened this issue Jul 31, 2024 · 1 comment
Open

Add Service Annotations to the DevWorkspaceRouting CRD #1293

AObuchow opened this issue Jul 31, 2024 · 1 comment

Comments

@AObuchow
Copy link
Collaborator

In order to resolve #1023 we need to allow DevWorkspaceRouting objects to contain annotations which should be applied to the service created for a workspace.

Based on devfile/api#632 (comment), it seems like the service annotations from all of the devworkspace's container components should be aggregated and added as annotations to the workspace's service:

As discussed in today's call, we changed the proposal to have container level annotation defines deployment & service annotation, and move ingress/route annotation to endpoint level.
Since currently we have all containers defined within same pod share the same service. In the future, if we want to have multiple services for a same pod, we can add service annotation to endpoint level, which takes priority to container level service annotation and overwrites it when generating the service resource spec.

@AObuchow
Copy link
Collaborator Author

Once this issue is resolved, a follow-up issue would be to support component.annotations.service from the devfile API. Another issue should be made for that topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant