init commit

Author: sbmsr

README.md

@@ -2,7 +2,7 @@
 
 # django-rest-backend by Jobsimulator.dev
 
-This is an Django-based Pokémon REST API based on PokeAPI. Your job is to fix 5 issues:
+This is an Django-based Pokémon REST API. Your job is to fix 5 issues:
 
 1. [Update `/pokemon` endpoint to include a Pokémon's type.](https://github.com/developer-job-simulation/django-rest-backend/issues/1)
 1. [Implement Get Pokémon by ID](https://github.com/developer-job-simulation/django-rest-backend/issues/2)

pokemon/serializers.py

@@ -4,16 +4,10 @@
 
 # TODO: Add a serializer for PokemonTypes, and use it as a nested serializer for PokemonSerializer
 
-class PokemonTypeSerializer(serializers.ModelSerializer):
-    class Meta:
-        model = PokemonTypes
-        fields = ('type',)
-
 
 class PokemonSerializer(serializers.ModelSerializer):
-    types = PokemonTypeSerializer(many=True)
 
     class Meta:
         model = Pokemon
         fields = ('id', 'name_english', 'name_japanese', 'name_chinese', 'name_french', 'hp', 'attack', 'defense',
-                  'special_attack', 'special_defense', 'speed', 'types',)
+                  'special_attack', 'special_defense', 'speed', )

pokemon/views.py

@@ -1,4 +1,4 @@
-from django.http import JsonResponse
+from django.http import JsonResponse, HttpResponse
 from django.views.decorators.csrf import csrf_exempt
 from rest_framework.decorators import api_view
 
@@ -23,12 +23,8 @@ def pokemon_by_id(request, id):
     """
     Get Pokemon by ID
     """
-    try:
-        pokemon = Pokemon.objects.get(pk=id)
-        serializer = PokemonSerializer(pokemon)
-        return JsonResponse(serializer.data, safe=False, json_dumps_params={'ensure_ascii': False})
-    except Exception as e:
-        return JsonResponse({'error': 'Not found'}, status=404)
+    # TODO: Implement Endpoint
+    return HttpResponse(status=501)
 
 
 @csrf_exempt
@@ -37,55 +33,23 @@ def pokemon_by_name(request, name):
     """
     Get Pokemon by name
     """
-    pokemon = Pokemon.objects.filter(name_english__iexact=name)
-    if len(pokemon) == 0:
-        return JsonResponse({'error': 'Not found'}, status=404)
-    serializer = PokemonSerializer(pokemon.first())
-    return JsonResponse(serializer.data, safe=False, json_dumps_params={'ensure_ascii': False})
+    # TODO: Implement Endpoint
+    return HttpResponse(status=501)
 
 
 @csrf_exempt
 def pokemon_by_type(request, pokemon_type):
     """
     Get Pokemon by type
     """
-    pokemon_type = pokemon_type.lower().capitalize()
-    if VALID_POKEMON_TYPES.count((pokemon_type, pokemon_type)) == 0:
-        return JsonResponse({'error': 'Bad request'}, status=400)
-    pokemon = Pokemon.objects.filter(types__type__iexact=pokemon_type)
-    if len(pokemon) == 0:
-        return JsonResponse({'error': 'Not found'}, status=404)
-    serializer = PokemonSerializer(pokemon, many=True)
-    return JsonResponse(serializer.data, safe=False, json_dumps_params={'ensure_ascii': False})
+    # TODO: Implement Endpoint
+    return HttpResponse(status=501)
 
 
 @csrf_exempt
 def pokemon_by_hp(request):
     """
     Get Pokemon by HP
     """
-    pokemon = Pokemon.objects.all()
-    lt = request.GET.get('lt')
-    gt = request.GET.get('gt')
-    lte = request.GET.get('lte')
-    gte = request.GET.get('gte')
-
-    valid_query_params = set(['lt', 'gt', 'lte', 'gte'])
-
-    if not set(request.GET.keys()) <= valid_query_params:
-        return JsonResponse({'error': 'Invalid Operator. Must be one of ["gt","gte","lt","lte"]'}, status=400)
-
-    if lt is not None:
-        pokemon = pokemon.filter(hp__lt=int(lt))
-    if gt is not None:
-        pokemon = pokemon.filter(hp__gt=int(gt))
-    if gte is not None:
-        pokemon = pokemon.filter(hp__gte=int(gte))
-    if lte is not None:
-        pokemon = pokemon.filter(hp__lte=int(lte))
-
-    if len(pokemon) == 0:
-        return JsonResponse({'error': 'Not found'}, status=404)
-
-    serializer = PokemonSerializer(pokemon, many=True)
-    return JsonResponse(serializer.data, safe=False, json_dumps_params={'ensure_ascii': False})
+    # TODO: Implement Endpoint
+    return HttpResponse(status=501)