Skip to content

Search doesn't work on Templates #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bamurtaugh opened this issue Feb 22, 2024 · 4 comments · Fixed by #358 or #359
Closed

Search doesn't work on Templates #357

bamurtaugh opened this issue Feb 22, 2024 · 4 comments · Fixed by #358 or #359
Assignees

Comments

@bamurtaugh
Copy link
Member

#325 added search functionality across the Features, Templates, and Collections pages. The search works well on Features and Collections but doesn't seem to work for me on Templates.

@samruddhikhandale do you see the same behavior? And do you have any recommendations for how to test this locally (as mentioned in #325, I can test Collections pretty easily since they load when I build and run the site locally, but Features and Templates don't populate locally for me when testing).

@bamurtaugh bamurtaugh self-assigned this Feb 22, 2024
@samruddhikhandale
Copy link
Member

@samruddhikhandale do you see the same behavior?

Yes, I see the "Search" not working for Templates. However, for Features and collections it works perfectly.

I can test Collections pretty easily since they load when I build and run the site locally, but Features and Templates don't populate locally for me when testing

Even I tried testing locally and saw the same here, I'd need to investigate the problem.

The issue with the search functionality is that it's trying to access a third td element in each row, which doesn't exist. The table only has two td elements per row: one for the template name and one for the maintainer. This line seems problematic.

@bamurtaugh
Copy link
Member Author

The issue with the search functionality is that it's trying to access a third td element in each row, which doesn't exist. The table only has two td elements per row: one for the template name and one for the maintainer. This line seems problematic.

Ah that's a great catch, thank you! Opened #358.

@bamurtaugh
Copy link
Member Author

Unfortunately looks like the latest PR didn't fix things ☹ so reopening this issue.

@bamurtaugh
Copy link
Member Author

Found another reference to a non-existent column so opened another PR: #359.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants